Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retinotopy improvements #407

Closed
4 tasks
rly opened this issue Feb 6, 2020 · 3 comments
Closed
4 tasks

Retinotopy improvements #407

rly opened this issue Feb 6, 2020 · 3 comments

Comments

@rly
Copy link
Contributor

rly commented Feb 6, 2020

From Jerome Lecoq at the hackathon:

  • sign_map should be optional
  • phase maps and vasculature image are the most important. power maps should be optional
  • improve documentation based on discussion with Jerome
  • focal_depth_image should be optional
@bendichter
Copy link
Contributor

I suggest we demote retinotopy to an extension. @rly, what do you think?

@rly
Copy link
Contributor Author

rly commented Oct 27, 2020

I agree. This will take significantly more time to fix and meet user needs, so it would be best not to have it in the core schema until that is done. I am sure no one is using these types in NWB 2 -- these types do not roundtrip with PyNWB, so we would hear about bugs there if users were using it. Some users may be using it in MatNWB but we have not seen any evidence of that in the last couple of years. And there are no tutorials or known scripts that use these types in NWB 2.

I suggest we first deprecate these types in the next minor version (2.3.0) with warnings in the APIs, even though this is a significant change. Then we work on the extension. In NWB 2.4.0, we would remove the types unless the extension is ready to be integrated. @oruebel @ajtritt thoughts?

@stephprince
Copy link
Contributor

Closing because ImagingRetinotopy has been deprecated with #565.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants