Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to retinotopy.yaml #409

Merged
merged 3 commits into from
Feb 8, 2020
Merged

Revert changes to retinotopy.yaml #409

merged 3 commits into from
Feb 8, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 8, 2020

  1. Revert the changes that were made in Refactor ImagingRetinotopy type to reduce redundancy #304 that reduced redundancy in the imaging retinotopy schema by way of introducing new neurodata types. These new types create a challenge for the APIs to read files created with an earlier version of ImagingRetinotopy that do not have the core spec cached. For the time being, until the API can be updated appropriately, these changes will be put on hold.

  2. Apply some of the non-breaking changes from Refactor ImagingRetinotopy type to reduce redundancy #304 in specifying shape, and clarifying docs, dtype, and dims

  3. Make sign_map and focal_depth_image datasets optional -- see Retinotopy improvements #407

@rly rly requested a review from oruebel February 8, 2020 01:23
@rly rly merged commit feddcbf into dev Feb 8, 2020
@rly rly deleted the revert/retinotopy branch February 8, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants