Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link check workflow and fix broken links #562

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

stephprince
Copy link
Contributor

@stephprince stephprince commented Dec 12, 2023

Summary of changes

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.

If this is the first schema change after a schema release (i.e., the version string in core/nwb.namespace.yaml does not
end in "-alpha"), then:

  • Update the version string in core/nwb.namespace.yaml and core/nwb.file.yaml to the next major/minor/patch
    version with the suffix "-alpha". For example, if the current version is 2.4.0 and this is a minor change, then the
    new version string should be "2.5.0-alpha".
  • Update the value of the version variable in docs/format/source/conf.py to the next version without the
    suffix "-alpha", e.g., "2.5.0".
  • Update the value of the release variable in docs/format/source/conf.py to the next version with the suffix
    "-alpha", e.g., "2.5.0-alpha".
  • Add a new section in the release notes docs/format/source/format_release_notes.rst for the new version
    with the date "Upcoming" in parentheses.

@stephprince stephprince marked this pull request as ready for review December 12, 2023 21:49
@stephprince stephprince requested a review from rly December 12, 2023 21:50
@rly
Copy link
Contributor

rly commented Dec 12, 2023

Thank you @stephprince ! This looks good. I would like to merge #560 first which addresses unrelated repo issues.

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@stephprince stephprince merged commit 6ce41fa into dev Dec 19, 2023
5 checks passed
@stephprince stephprince deleted the check-external-internal-links branch December 19, 2023 22:22
@rly rly mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Action to check external and internal links
3 participants