Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExternalImage #604

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Add ExternalImage #604

merged 4 commits into from
Feb 20, 2025

Conversation

h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Jan 27, 2025 •
edited
Loading

Summary of changes

Fix #603

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
  • Make sure that hdmf-common-schema points to the latest release and not the latest commit on the main branch.

@h-mayorquin h-mayorquin mentioned this pull request Jan 27, 2025
Closed
1 task
@h-mayorquin
Copy link
Contributor Author

The spelling error is unrelated to my changes but happy to correct it if the spelling is in fact wrong.

@h-mayorquin h-mayorquin mentioned this pull request Feb 18, 2025
Open
@h-mayorquin h-mayorquin marked this pull request as ready for review February 18, 2025 17:53
rly
rly reviewed Feb 18, 2025
View reviewed changes
rly
rly reviewed Feb 18, 2025
View reviewed changes
rly
rly reviewed Feb 18, 2025
View reviewed changes
@rly rly merged commit 5cfe01d into NeurodataWithoutBorders:dev Feb 20, 2025
4 checks passed
@h-mayorquin h-mayorquin deleted the add_external_image branch February 20, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly rly approved these changes

@bendichter bendichter Awaiting requested review from bendichter

@oruebel oruebel Awaiting requested review from oruebel

@stephprince stephprince Awaiting requested review from stephprince

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Introduce ExternalImage Data Type
2 participants
@h-mayorquin @rly