Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links for notebooks #1108

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

steevelaquitaine
Copy link
Contributor

Hi, I have updated the notebook urls. They were broken.

@iamzoltan iamzoltan changed the base branch from main to dataset-hot-fix July 5, 2024 20:37
Copy link
Contributor

@iamzoltan iamzoltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamzoltan iamzoltan merged commit 81f9675 into NeuromatchAcademy:dataset-hot-fix Jul 5, 2024
@steevelaquitaine
Copy link
Contributor Author

Hi @iamzoltan, thank you for accepting the pull request but after checking the https://compneuro.neuromatch.io/projects/docs/project_templates.html, the fix is still not implemented, when I click on the links on the project template. Is there something else that needs to be done to update the jupyterbook? Is the jupyterbook produced by the correct branch?

@iamzoltan
Copy link
Contributor

The change is not implemented because another PR that I am grouping with this fix is not working. The book will not rebuild until all checks pass. See: #1109

@steevelaquitaine
Copy link
Contributor Author

Ok great thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants