-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Hormann BiSecur readability in SubGHz history #119
Improve Hormann BiSecur readability in SubGHz history #119
Conversation
Adding shorthand's there would get cumbersome quickly with how many protocols there are, and I don't think starting to do that would be the best idea. We can use a shorthand in the protocols name, could do BiSec or BSec or BS instead of the full "BiSecur" |
What about adding a new API method, so the protocol can provide code to generate its SubGHz history line string? I see you already added a custom member to the struct (long hash), so the BC is already broken. For this protocol there's lots of data, so in order to make sense I would format is as follows:
Unrelated to this, the three repetitions of the packet (generated with a single button press) are send 504.3 ms apart, so they appear as a separare decoded messages, since the duplocation threshold is set to 500 ms. Not sure if it makes sense to bump this, because the x2 and x3 markers at the start of the lines eat up valuable space. |
55588a2
to
39aa476
Compare
39aa476
to
1427f98
Compare
1427f98
to
d780c55
Compare
The final format, which looks good on the flipper screen is: |
…ecure remotes. They transmit the 2FSK data 3 times, with a 504.3 ms pause, which is enough to show them as three separate signals, although they are absolutely identical. On the flipper, that's measured between 578 and 591 ms.
43f0572
to
0a40b34
Compare
A two-byte data hash will make things more clear, and still fit on the same line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What's new
For the reviewer