Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFC: Goofy ISO15693 block sizes? #274

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

NFC: Goofy ISO15693 block sizes? #274

wants to merge 3 commits into from

Conversation

Willy-JL
Copy link
Member

What's new

  • some tags seem to report block size/count values -1 than real values
  • others dont, so they dont read correctly with existing code
  • this is just for testing, its a shitty solution, just to see if this is the actual problem

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL
Surely this was a typo right?
d1fc6b3
@Willy-JL
So some tags lie on their block size/count?
0b5145b 
apparently some tags encode values 1 less than real values, others return real values

i have a slix card that reports 79x3 blocks, when theyre actually 80x4, so it worked fine

this person i know has a card that reports 50x8 blocks, which is the correct one, but the code increased it to 51x9 and so it doesnt read

clearly, people are mad, and there is no logic
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 20, 2024 •
edited
Loading

Compiled f7 firmware for commit aae6ccc1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 will be requested when the pull request is marked ready for review Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam will be requested when the pull request is marked ready for review HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich will be requested when the pull request is marked ready for review MatthewKuKanich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Willy-JL