Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Add warnings for settings you shouldn't touch #296

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Settings: Add warnings for settings you shouldn't touch #296

merged 3 commits into from
Nov 10, 2024

Conversation

Willy-JL
Copy link
Member

@Willy-JL Willy-JL commented Nov 10, 2024 •
edited
Loading

What's new

  • warnings for some settings: debug, heap trace, sleep mode
  • hopefully will stop people enabling debug for no reason and crying that battery drains too fast

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL Willy-JL added the enhancement New enhancement or request label Nov 10, 2024
@Willy-JL Willy-JL self-assigned this Nov 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2024 •
edited
Loading

Compiled f7 firmware for commit 2d559a15:

@Willy-JL Willy-JL merged commit 8b84222 into dev Nov 10, 2024
5 checks passed
@Willy-JL Willy-JL deleted the feat/settings-warnings branch November 10, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@Willy-JL Willy-JL

Labels
enhancement New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Willy-JL