Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hid_ptt): support Gather #304

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(hid_ptt): support Gather #304

wants to merge 1 commit into from

Conversation

SapphicCode
Copy link

@SapphicCode SapphicCode commented Nov 19, 2024 •
edited
Loading

What's new

  • Adds Gather keybindings to hid_ptt
  • A few typo & style fixes (Slack Hubble -> Slack Huddle)

Todos

  • I have built the firmware and uploaded it to my device
  • I have verified functionality on Gather / macOS
  • I have verified functionality on Gather / Linux

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@SapphicCode
feat(hid_ptt): support Gather
e265ebb 
plus a few typo and style fixes...
@SapphicCode SapphicCode marked this pull request as ready for review November 21, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Awaiting requested review from Willy-JL Willy-JL is a code owner

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SapphicCode