[Feat] network 기초 세팅, RetrofitModule, ServiceModule 구현 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murjune
force-pushed
the
feature/set-network-module
branch
2 times, most recently
from
b8817c1 to
d1b8708
Compare
murjune
force-pushed
the
feature/set-network-module
branch
from
d1b8708 to
c356314
Compare
murjune
force-pushed
the
feature/set-network-module
branch
from
55c8947 to
5680ffe
Compare
murjune
changed the title
murjune
commented
Jan 29, 2024
Comment on lines
+18
to
+24
| getByName("release") { | ||
| buildConfigField( | ||
| "String", | ||
| "FUNCH_DEBUG_BASE_URL", | ||
| properties.getProperty("FUNCH_DEBUG_BASE_URL"), | ||
| ) | ||
| } |
There was a problem hiding this comment.
release 버전도 buildConfig 설정 해줘야함
murjune
requested review from
a team
and removed request for
a team and
ham2174
ham2174
approved these changes
Jan 31, 2024
Comment on lines
+18
to
+24
| getByName("release") { | ||
| buildConfigField( | ||
| "String", | ||
| "FUNCH_DEBUG_BASE_URL", | ||
| properties.getProperty("FUNCH_DEBUG_BASE_URL"), | ||
| ) | ||
| } |
murjune
force-pushed
the
feature/set-network-module
branch
from
b5d0380 to
c6b17da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
컨벤션 정한거
dto
json Parser