feat(NexusViewer): add pool manager NXM locked for MV timestamp #1280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative for UI multicall https://github.com/NexusMutual/frontend-next/pull/1049 to support https://github.com/NexusMutual/frontend-next/issues/1044.
The advantage of this approach would be saving an on chain call on the UI, the disadvantage being this implies a smart contract deployment + not sure about how computationally heavy the added logic is. The UI approach is faster in terms of going live with the fix, but I don't think this is an urgent issue so we can decide based on the other criteria.
Testing
NexusViewer implementation address: 0x6874ABAf1c8a1694b08066e5bB38487D680fa38d
NexusViewer implementation ABI:
getClaimableNXM
call should returnstakingPoolManagerIsNXMLockedForMV
in the resultOR
HARDHAT_NETWORK=localhost node scripts/get-claimable-nxm.js
Checklist