Don't send meta packets during syncing

src/main/java/xiamomc/morph/backends/server/renderer/network/PacketFactory.java

@@ -96,7 +96,6 @@ public List<PacketContainer> buildSpawnPackets(Player player, DisplayParameters
         packets.add(PacketContainer.fromPacket(equipmentPacket));
 
         var watcher = parameters.getWatcher();
-        watcher.sync();
         packets.add(buildFullMetaPacket(player, watcher));
 
         for (PacketContainer packet : packets)
@@ -143,6 +142,8 @@ public PacketContainer buildDiffMetaPacket(Player player, SingleWatcher watcher)
 
     public PacketContainer buildFullMetaPacket(Player player, SingleWatcher watcher)
     {
+        watcher.sync();
+
         var metaPacket = new PacketContainer(PacketType.Play.Server.ENTITY_METADATA);
         metaPacket.getIntegers().write(0, player.getEntityId());
 

src/main/java/xiamomc/morph/backends/server/renderer/network/datawatcher/watchers/SingleWatcher.java

@@ -157,7 +157,9 @@ public void write(int index, Object value)
         dirtySingles.put(single, value);
 
         onTrackerWrite(index, prev, value);
-        sendPacketToAffectedPlayers(packetFactory.buildDiffMetaPacket(getBindingPlayer(), this));
+
+        if (!syncing)
+            sendPacketToAffectedPlayers(packetFactory.buildDiffMetaPacket(getBindingPlayer(), this));
     }
 
     @Resolved(shouldSolveImmediately = true)
@@ -204,10 +206,25 @@ public Map<SingleValue<?>, Object> getDirty()
 
     //endregion Value Registry
 
+    private boolean syncing;
+
     public void sync()
     {
+        syncing = true;
+
         dirtySingles.clear();
-        doSync();
+
+        try
+        {
+            doSync();
+        }
+        catch (Throwable t)
+        {
+            logger.warn("Error occurred while syncing watcher: " + t.getMessage());
+            t.printStackTrace();
+        }
+
+        syncing = false;
     }
 
     protected void doSync()

src/main/java/xiamomc/morph/backends/server/renderer/network/listeners/MetaPacketListener.java

@@ -51,7 +51,6 @@ private void onMetaPacket(ClientboundSetEntityDataPacket packet, PacketEvent pac
             return;
 
         //取得来源玩家的伪装后的Meta，发送给目标玩家
-        watcher.sync();
         packetEvent.setPacket(getFactory().buildFullMetaPacket(sourcePlayer, watcher));
     }