Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perp): Add TraderVolume tracking #1575

Merged
merged 8 commits into from
Sep 15, 2023
Merged

feat(perp): Add TraderVolume tracking #1575

merged 8 commits into from
Sep 15, 2023

Conversation

testinginprod
Copy link
Collaborator

@testinginprod testinginprod commented Sep 13, 2023 •
edited by Unique-Divine
Loading

Description

Adds a way to track the user volume on successful position changes.

Purpose

Enables discounts and rebates.

@testinginprod testinginprod requested a review from a team as a code owner September 13, 2023 14:29
@testinginprod testinginprod marked this pull request as draft September 13, 2023 14:29
@testinginprod testinginprod changed the title Tip/dnr/volumes feat(perp/dnr): Add TraderVolume tracking Sep 13, 2023
@testinginprod testinginprod changed the title feat(perp/dnr): Add TraderVolume tracking feat(perp): Add TraderVolume tracking Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #1575 (08d524a) into master (0f2169e) will decrease coverage by 0.06%.
Report is 3 commits behind head on master.
The diff coverage is 61.25%.

❗ Current head 08d524a differs from pull request most recent head 2b45805. Consider uploading reports for the commit 2b45805 to get more accurate results

@@            Coverage Diff             @@
##           master    #1575      +/-   ##
==========================================
- Coverage   70.77%   70.72%   -0.06%     
==========================================
  Files         180      181       +1     
  Lines       14786    14865      +79     
==========================================
+ Hits        10465    10513      +48     
- Misses       3645     3668      +23     
- Partials      676      684       +8
Files Changed Coverage
x/perp/v2/module/genesis.go 31.81%
x/perp/v2/keeper/dnr.go 65.95%
x/perp/v2/keeper/clearing_house.go 100.00%
x/perp/v2/keeper/keeper.go 100.00%

@testinginprod testinginprod marked this pull request as ready for review September 13, 2023 18:40
Unique-Divine
Unique-Divine requested changes Sep 13, 2023
View reviewed changes
@testinginprod testinginprod enabled auto-merge (squash) September 15, 2023 16:56
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
16.2% 16.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@testinginprod testinginprod merged commit a35ade1 into master Sep 15, 2023
@testinginprod testinginprod deleted the tip/dnr/volumes branch September 15, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unique-Divine Unique-Divine Unique-Divine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(perp): Add trader volume tracking
2 participants
@testinginprod @Unique-Divine