feat(perp): Add user discounts #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testinginprod
commented
Sep 19, 2023
|
|
||
| repeated Discount global_discount = 8 [ (gogoproto.nullable) = false ]; | ||
|
|
||
| repeated CustomDiscount custom_discounts = 9 [ (gogoproto.nullable) = false ]; |
There was a problem hiding this comment.
this proto breakage should be fine since unreleased, so we can group dnr genesis
added 2 commits
September 19, 2023 14:25
added 3 commits
September 20, 2023 10:50
# Conflicts: # CHANGELOG.md
|
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## master #1594 +/- ##
==========================================
+ Coverage 71.21% 71.53% +0.31%
==========================================
Files 186 186
Lines 14493 14588 +95
==========================================
+ Hits 10321 10435 +114
+ Misses 3520 3505 -15
+ Partials 652 648 -4
|
k-yang
approved these changes
Sep 26, 2023
Unique-Divine
requested changes
Sep 26, 2023
jgimeno
reviewed
Sep 27, 2023
jgimeno
reviewed
Sep 27, 2023
jgimeno
reviewed
Sep 27, 2023
jgimeno
reviewed
Sep 27, 2023
jgimeno
approved these changes
Sep 27, 2023
Unique-Divine
approved these changes
Sep 29, 2023
Unique-Divine
pushed a commit
that referenced
this pull request
Sep 29, 2023
* add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]>
Unique-Divine
added a commit
that referenced
this pull request
Sep 29, 2023
test(tokenfactory): more CLI test coverage feat(perp): Add user discounts (#1594) * add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]> feat(perp): Add user discounts (#1594) * add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]>
jgimeno
added a commit
that referenced
this pull request
Oct 3, 2023
…ModuleParams (#1607) * (proto): add some txs and events for token factory * #wip msg handlers impl * fix grpc query test * test(tokenfactory): validate basic and msg server tests * test(tokenfactory): update module params * fix(tokenfactory): changelog, linter, put blank CLi commands instead of panic * test(tokenfactory): add case for if the denom is not registered in ChangeAdmin * token factory CLI tests and queries with tests * test(tokenfactory/types): more coverage * combo squashed commit: Resolves strange proto break error test(tokenfactory): more CLI test coverage feat(perp): Add user discounts (#1594) * add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]> feat(perp): Add user discounts (#1594) * add discounts * impl genesis * fix test * make test more robust * galaxy brain int encoding fix * test and optimise * lint * CHANGELOG.md * do merge * clarify fee variable names in applyDiscountAndRebate func * refactor dnr_test.go as per PR review * add genesis tests --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]> * ci(proto-lint): should refer to the PR, not just the last commit * ci(proto-lint): supply with github token in buf setup b/c rate limits --------- Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: godismercilex <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]> Co-authored-by: Matthias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies fee discounts based on the trader volume in the previous 30days.
Purpose