Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm): Deduct a fee during the creation of a FunToken mapping. Implemented by deductCreateFunTokenFee inside of the eth.evm.v1.MsgCreateFunToken transaction. #1963

Merged
merged 9 commits into from
Jul 12, 2024
Merged

feat(evm): Deduct a fee during the creation of a FunToken mapping. Implemented by deductCreateFunTokenFee inside of the eth.evm.v1.MsgCreateFunToken transaction. #1963

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
40cb618
docs,refactor(evm): more function docs and better code organization
Unique-Divine Jul 10, 2024
ebdebcc
add create_funtoken_fee to evm.Params
Unique-Divine Jul 10, 2024
e1d615a
feat(evm): impl deduct create_fun_token_fee
Unique-Divine Jul 11, 2024
67e110f
chore: changelog
Unique-Divine Jul 11, 2024
d6db062
chore: fix changelog PR number
Unique-Divine Jul 11, 2024
09afe2d
Merge branch 'main' into ud/funtoken-fee
Unique-Divine Jul 12, 2024
6f49104
chore: revert merge conflict change
Unique-Divine Jul 12, 2024
5d1f73c
chore: changelog typo
Unique-Divine Jul 12, 2024
2c8f323
chore: typo
Unique-Divine Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: revert merge conflict change
  • Loading branch information
@Unique-Divine
Unique-Divine committed Jul 12, 2024
commit 6f49104e0850e52f8f1ee56fb5e3fd02ac902b7e
6 changes: 3 additions & 3 deletions x/evm/keeper/funtoken_from_erc20.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (k *Keeper) CreateFunTokenFromERC20(
if funtokens := k.FunTokens.Collect(
ctx, k.FunTokens.Indexes.ERC20Addr.ExactMatch(ctx, erc20Addr),
); len(funtokens) > 0 {
return funtoken, fmt.Errorf("Funtoken mapping already created for ERC20 \"%s\"", erc20Addr.Hex())
return funtoken, fmt.Errorf("funtoken mapping already created for ERC20 \"%s\"", erc20Addr.Hex())
}

// 2 | Get existing ERC20 metadata
Expand All @@ -115,12 +115,12 @@ func (k *Keeper) CreateFunTokenFromERC20(
// 3 | Coin already registered with FunToken?
_, isAlreadyCoin := k.bankKeeper.GetDenomMetaData(ctx, bankDenom)
if isAlreadyCoin {
return funtoken, fmt.Errorf("Bank coin denom already registered with denom \"%s\"", bankDenom)
return funtoken, fmt.Errorf("bank coin denom already registered with denom \"%s\"", bankDenom)
}
if funtokens := k.FunTokens.Collect(
ctx, k.FunTokens.Indexes.BankDenom.ExactMatch(ctx, bankDenom),
); len(funtokens) > 0 {
return funtoken, fmt.Errorf("Funtoken mapping already created for bank denom \"%s\"", bankDenom)
return funtoken, fmt.Errorf("funtoken mapping already created for bank denom \"%s\"", bankDenom)
}

// 4 | Set bank coin denom metadata in state
Expand Down
Loading