refactor(evm): remove PostProcessing hooks #1965
Conversation
WalkthroughThis update introduces a precompile to the Ethereum Virtual Machine (EVM) within the Nibiru blockchain, enabling ERC20 token transfers to "nibi" accounts via regular Ethereum transactions. Additionally, it removes redundant post-processing hooks from the EVM to streamline transaction handling. These changes aim to enhance functionality and improve code maintainability by eliminating unnecessary dependencies. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EVM
participant NibiruAccount
User->>EVM: Initiate ERC20 Transfer
EVM->>NibiruAccount: Transfer tokens as regular Ethereum transaction
NibiruAccount->>User: Confirmation of Transfer
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
k-yang
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
CHANGELOG.md (1)
82-82: Correct Typographical Error.The word "trasnfers" should be corrected to "transfers".
- feat(evm): Add precompile to the EVM that enables trasnfers of ERC20 tokens to "nibi" accounts as regular Ethereum transactions + feat(evm): Add precompile to the EVM that enables transfers of ERC20 tokens to "nibi" accounts as regular Ethereum transactions
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- CHANGELOG.md (1 hunks)
- x/evm/deps.go (2 hunks)
- x/evm/keeper/keeper.go (3 hunks)
- x/evm/keeper/msg_server.go (2 hunks)
Files skipped from review due to trivial changes (1)
- x/evm/keeper/msg_server.go
Additional comments not posted (1)
CHANGELOG.md (1)
86-86: LGTM! Documenting EVM post-processing hooks removal.The changelog correctly documents the removal of EVM post-processing hooks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
==========================================
+ Coverage 65.91% 65.95% +0.04%
==========================================
Files 258 258
Lines 16397 16384 -13
==========================================
- Hits 10808 10806 -2
+ Misses 4780 4772 -8
+ Partials 809 806 -3
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- x/evm/keeper/msg_server.go (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- CHANGELOG.md
- x/evm/keeper/msg_server.go
Purpose / Abstract
Originally, the EVM post processing hooks were meant to allow EVM to talk to native Cosmos modules, but we are using precompiles for that now.
Summary by CodeRabbit
New Features
Refactor