Changed large if-else to use a HashMap #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passes the tests whether it's there or not!
map a field of the class that is instantiated by a method
Conflicts: src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
|
Note that the Bukkit folks want pull requests to be on a new branch whose name indicates something about the change being implemented. I can merge this into a new branch on my version, but it would be better if you created a branch on your end, merged these changes to that branch, and then issued the pull request from the new branch. |
|
Nice clean refactoring, although your write-up doesn't really match the CraftBukkit pull request specifications at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a hashmap field to the class, that takes a DamageSource and returns a DamageCause. This HM is instantiated in a discrete method that is called on initialization. The HM eliminates the need for a lengthy if-else series, and simplifies the addition of new damage sources and causes.