Skip to content

Commit

Permalink
Use dummy file for FBReactNativeSpecs.podspec so that it doesn't incl…
Browse files Browse the repository at this point in the history
…ude any files even there are old files.

Summary:
FBReactNativeSpecs.podspec is currently only acting as a config for codegen. It should not include any sources. This would fix unintended build error related to FBReactNativeSpecs-generated file.

Changelog: [internal]

Reviewed By: philIip

Differential Revision: D32267102

fbshipit-source-id: 27b510198666dc26a890cd7a6f873a04a9df66ca
  • Loading branch information
sota000 authored and facebook-github-bot committed Nov 11, 2021
1 parent f249d21 commit 751708d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion React/FBReactNativeSpec/FBReactNativeSpec.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ Pod::Spec.new do |s|
s.platforms = { :ios => "11.0" }
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
s.source = source
s.source_files = "**/FBReactNativeSpec*.{h,mm}"
# This podspec is used to trigger the codegen, and built files are generated in a different location.
# We don't want this pod to actually include any files.
s.header_dir = "FBReactNativeSpec"

s.pod_target_xcconfig = {
Expand Down
6 changes: 3 additions & 3 deletions packages/rn-tester/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ SPEC CHECKSUMS:
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
DoubleConversion: 831926d9b8bf8166fd87886c4abab286c2422662
FBLazyVector: b81a2b70c72d8b0aefb652cea22c11e9ffd02949
FBReactNativeSpec: cd36c48651d54982428c1b0afd5557993b45e92c
FBReactNativeSpec: 745a95c0786e7b97aa2fb6f65c6ae35d2083fe57
Flipper: 30e8eeeed6abdc98edaf32af0cda2f198be4b733
Flipper-Boost-iOSX: fd1e2b8cbef7e662a122412d7ac5f5bea715403c
Flipper-DoubleConversion: 57ffbe81ef95306cc9e69c4aa3aeeeeb58a6a28c
Expand Down Expand Up @@ -923,10 +923,10 @@ SPEC CHECKSUMS:
React-RCTTest: 12bbd7fc2e72bd9920dc7286c5b8ef96639582b6
React-RCTText: e9146b2c0550a83d1335bfe2553760070a2d75c7
React-RCTVibration: 50be9c390f2da76045ef0dfdefa18b9cf9f35cfa
React-rncore: fb776508453c32c72c6325f421468eb8a1f3e2c4
React-rncore: e7f0e8fa2147c908ae2a96f048d5adb2b7dee1e8
React-runtimeexecutor: 4b0c6eb341c7d3ceb5e2385cb0fdb9bf701024f3
ReactCommon: 7a2714d1128f965392b6f99a8b390e3aa38c9569
ScreenshotManager: b6b23f4913712a245102024854656634fee33265
ScreenshotManager: 7720a2413a1ea43287bf355535fdc6ef34ccffba
Yoga: c0d06f5380d34e939f55420669a60fe08b79bd75
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

Expand Down

0 comments on commit 751708d

Please sign in to comment.