Skip to content

Commit

Permalink
Enable Indexed Access Types in Xplat
Browse files Browse the repository at this point in the history
Summary:
Enable Flow's Indexed Access Types (https://flow.org/en/docs/types/indexed-access/) in Xplat.

These are a replacement for `$ElementType` and `$PropertyType`.

Changelog: [Internal]

Remove `$FlowFixMe[indexed-access-off]`: `flow --json | jq -r ".errors[].message[0].path" | sort | uniq | xargs sed -i '/indexed-access-off/ d'`
Suppress new errors: `~/fbsource/xplat/js/scripts/flow/tool add-comments ~/fbsource/xplat/js/RKJSModules/public/XPlatReact/FXDemoShared/ --all --comment "Automatically suppressed"`
Re-sign: `hg st -n | grep '\.js$' | xargs --no-run-if-empty grep -lE 'generated|partially-generated'| xargs -n 1 -P 8 ~/fbsource/tools/signedsource sign`

Reviewed By: yungsters

Differential Revision: D32142892

fbshipit-source-id: 442092c497232750c729125383c9f4edcefbb6b1
  • Loading branch information
gkz authored and facebook-github-bot committed Nov 9, 2021
1 parent 7f80220 commit ecfb637
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ flow/
emoji=true

exact_by_default=true
indexed_access=false

format.bracket_spacing=false

Expand Down
1 change: 0 additions & 1 deletion .flowconfig.android
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ flow/
emoji=true

exact_by_default=true
indexed_access=false

format.bracket_spacing=false

Expand Down

0 comments on commit ecfb637

Please sign in to comment.