Linux - Setup libsecret

.github/workflows/linux.yml

@@ -30,6 +30,10 @@ jobs:
         uses: actions/checkout@v4
         with:
           submodules: recursive
+      - name: "Setup libsecret"
+      - run: |
+	  sudo apt install libsecret-1-0 libsecret-1-dev libglib2.0-dev
+	  sudo make --directory=/usr/share/doc/git/contrib/credential/libsecret
       - name: "Get Conan"
         uses: turtlebrowser/get-conan@main
       - name: "Setup Conan Settings"

include/keyring/systemcredentials.h

@@ -20,13 +20,13 @@ namespace Nickvision::Aura::Keyring::SystemCredentials
 	 */
 	std::optional<Credential> addCredential(const std::string& name);
 	/**
-	 * @brief Adds a new credential to the system's credential manager.
+	 * @brief Adds a new credential to the system's credential manager. On Linux, only the name and password of a credential will be stored. On Windows, all fields of a credential will be stored.
 	 * @param name The new credential object
 	 * @return True if successful, else false
 	 */
 	bool addCredential(const Credential& credential);
 	/**
-	 * @brief Updates a credential in the system's credential manager.
+	 * @brief Updates a credential in the system's credential manager. On Linux, only the name and password of a credential will be stored. On Windows, all fields of a credential will be stored.
 	 * @param name The updated credential object
 	 * @return True if successful, else false
 	 */

src/keyring/systemcredentials.cpp

@@ -47,7 +47,7 @@ namespace Nickvision::Aura::Keyring
 	std::optional<Credential> SystemCredentials::addCredential(const std::string& name)
 	{
 		PasswordGenerator passGen;
-		Credential c{ name, "", "NickvisionKeyring", passGen.next() };
+		Credential c{ name, "", "default", passGen.next() };
 		if (addCredential(c))
 		{
 			return c;