Tests - Better Aura Tests

include/configurationbase.h

@@ -1,6 +1,7 @@
 #ifndef CONFIGURATIONBASE_H
 #define CONFIGURATIONBASE_H
 
+#include <filesystem>
 #include <string>
 #include <json/json.h>
 #include "events/event.h"
@@ -18,6 +19,9 @@ namespace Nickvision::Aura
 		 * @param key The key of the config file
 		 */
 		ConfigurationBase(const std::string& key);
+		/**
+		 * @brief Deconstructs a ConfigurationBase. 
+		 */
 		virtual ~ConfigurationBase() = default;
 		/**
 		 * Gets the key of the config file.
@@ -31,13 +35,17 @@ namespace Nickvision::Aura
 		Events::Event<Events::EventArgs>& saved();
 		/**
 		 * @brief Saves the config file to disk. 
+		 * @return True if saved to disk, else false
 		 */
-		void save();
+		bool save();
 
 	protected:
 		Json::Value m_json;
 		std::string m_key;
 		Events::Event<Events::EventArgs> m_saved;
+
+	private:
+		std::filesystem::path m_path;
 	};
 }
 

src/configurationbase.cpp

@@ -6,12 +6,12 @@
 namespace Nickvision::Aura
 {
 	ConfigurationBase::ConfigurationBase(const std::string& key)
-		: m_key{ key }
+		: m_key{ key },
+		m_path{ UserDirectories::getApplicationConfig() / (key + ".json") }
 	{
-		std::filesystem::path path{ UserDirectories::getApplicationConfig() / (key + ".json") };
-		if (std::filesystem::exists(path))
+		if (std::filesystem::exists(m_path))
 		{
-			std::ifstream in{ path };
+			std::ifstream in{ m_path };
 			in >> m_json;
 		}
 	}
@@ -26,14 +26,15 @@ namespace Nickvision::Aura
 		return m_saved;
 	}
 
-	void ConfigurationBase::save()
+	bool ConfigurationBase::save()
 	{
 		if (m_key.empty())
 		{
-			throw std::invalid_argument("Key must not be empty.");
+			return false;
 		}
-		std::ofstream out{ UserDirectories::getApplicationConfig() / (m_key + ".json") };
+		std::ofstream out{ m_path };
 		out << m_json;
 		m_saved.invoke({});
+		return true;
 	}
 }

tests/auratests.cpp

@@ -1,5 +1,7 @@
 #include <gtest/gtest.h>
 #include "aura.h"
+#include "dependencylocator.h"
+#include "userdirectories.h"
 
 using namespace Nickvision::Aura;
 
@@ -15,7 +17,7 @@ class AppConfig : public ConfigurationBase
 public:
 	AppConfig(const std::string& key) : ConfigurationBase(key) 
 	{ 
-	
+
 	}
 
 	Theme getTheme() const
@@ -53,12 +55,31 @@ TEST_F(AuraTest, ChangeAppConfig)
 {
 	AppConfig& config{ Aura::getActive().getConfig<AppConfig>("config") };
 	config.setTheme(Theme::Light);
+	ASSERT_TRUE(config.save());
 	ASSERT_EQ(config.getTheme(), Theme::Light);
-	ASSERT_NO_THROW(config.save());
 }
 
 TEST_F(AuraTest, EnsureChangeInAppConfig)
 {
 	AppConfig& config{ Aura::getActive().getConfig<AppConfig>("config") };
 	ASSERT_EQ(config.getTheme(), Theme::Light);
-}
+}
+
+TEST_F(AuraTest, ResetAppConfig)
+{
+	ASSERT_TRUE(std::filesystem::remove(UserDirectories::getApplicationConfig() / ("config.json")));
+}
+
+#ifdef _WIN32
+TEST_F(AuraTest, DependencyCheckCmd)
+{
+	ASSERT_FALSE(DependencyLocator::find("cmd").empty());
+}
+#endif
+
+#ifndef _WIN32
+TEST_F(AuraTest, DependencyCheckLs)
+{
+	ASSERT_FALSE(DependencyLocator::find("ls").empty());
+}
+#endif