Feat/richer activation #79
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: client/src/pages/Prospecting/Prospecting.js
Did you find this useful? React with a 👍 or 👎 |
✅ Deploy Preview for gleeful-cascaron-9766fa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -31,18 +33,20 @@ import { | |||
| getPaginatedProspectingActivities, | |||
| } from "src/components/Api/Api"; | |||
| import CustomTable from "../../components/CustomTable/CustomTable"; | |||
| import ProspectingMetadataOverview from "../../components/ProspectingMetadataOverview/ProspectingMetadataOverview"; | |||
| import ProspectingEffortTimeline from "../../components/ProspectingEffortTimeline/ProspectingEffortTimeline"; | |||
| // import ProspectingMetadataOverview from "../../components/ProspectingMetadataOverview/ProspectingMetadataOverview"; | |||
There was a problem hiding this comment.
please remove comments
| onSearch={handleSearch} | ||
| /> | ||
|
|
||
| <Box sx={{ flexGrow: 1, marginTop: 5 }}> |
There was a problem hiding this comment.
This seems like it can go in its own component
There was a problem hiding this comment.
Possible or advisable to put all of the new view into an AccountDetail component?
| onPageChange: handlePageChange, | ||
| onRowsPerPageChange: handleRowsPerPageChange, | ||
| }} | ||
| sortConfig={{ |
There was a problem hiding this comment.
@ter1203 can you include this in the CustomTable within the AccountDetail compoent? You should be able to prop drill it exactly like you're doing with pagination config, when done correctly it should result in detail table rows getting sorted when you click a column.
|
@ter1203 Looks like the Account urls are redirecting to the app itself instead of Salesforce in the new table React.App.-.12.October.2024.mp4 |
effort-and-outcomes
…adata-grouping-api activation-detail-prospecting-metadata-grouping-api
Nickz22
temporarily deployed
to
feat/richer-activation - insideoutbound PR #79
Render
Destroyed
No description provided.