chore: fix ui libraries + their tests

NicolasFlamel1 · Aug 8, 2023 · 9e82a95 · 9e82a95
1 parent ea29896
commit 9e82a95
Show file tree

Hide file tree

Showing 8 changed files with 1,326 additions and 805 deletions.
diff --git a/.changeset/great-moose-deliver.md b/.changeset/great-moose-deliver.md
@@ -0,0 +1,9 @@
+---
+"@ledgerhq/crypto-icons-ui": patch
+"@ledgerhq/icons-ui": patch
+"@ledgerhq/native-ui": patch
+"@ledgerhq/react-ui": patch
+"@ledgerhq/ui-shared": patch
+---
+
+publish ui libraries with fixed tests
diff --git a/libs/ui/examples/next.js/.gitignore b/libs/ui/examples/next.js/.gitignore
@@ -0,0 +1 @@
+public
diff --git a/libs/ui/examples/next.js/package.json b/libs/ui/examples/next.js/package.json
@@ -12,10 +12,11 @@
     "clean:full": "npx rimraf .next node_modules public"
   },
   "dependencies": {
-    "@ledgerhq/react-ui": "*",
+    "@ledgerhq/react-ui": "workspace:^",
     "next": "13.2.4",
     "react": "18.2.0",
     "react-dom": "18.2.0",
+    "react-is": "*",
     "styled-components": "^5.3.3"
   }
 }
diff --git a/libs/ui/examples/webpack.js/package.json b/libs/ui/examples/webpack.js/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "webpack-example",
+  "name": "webpack.js-example",
   "private": true,
   "version": "0.0.1",
   "license": "MIT",
@@ -11,9 +11,10 @@
     "clean:full": "npx rimraf dist node_modules"
   },
   "dependencies": {
-    "@ledgerhq/react-ui": "*",
-    "react": "18.2.0",
-    "react-dom": "18.2.0",
+    "@ledgerhq/react-ui": "workspace:^",
+    "react": "^17.0.2",
+    "react-dom": "^17.0.2",
+    "react-is": "*",
     "styled-components": "^5.3.3"
   },
   "devDependencies": {
@@ -27,8 +28,8 @@
     "http-server": "^14.0.0",
     "react-refresh": "^0.10.0",
     "rimraf": "^3.0.2",
-    "webpack": "^5.62.2",
-    "webpack-cli": "^4.9.1",
-    "webpack-dev-server": "^4.4.0"
+    "webpack": "^5.88.2",
+    "webpack-cli": "^4.10.0",
+    "webpack-dev-server": "^4.15.1"
   }
 }
diff --git a/libs/ui/tests/react.script.js b/libs/ui/tests/react.script.js
@@ -4,33 +4,18 @@ const exampleName = process.argv[2] || "";
 
 const UPDATE_SNAPSHOTS = process.env["UPDATE_SNAPSHOTS"];
 
-const addPackageResolutions = `
-  pnpm json -I -f ./examples/${exampleName}/package.json -e 'this.pnpm={
-    "overrides": {
-      "@ledgerhq/react-ui": "../../packages/react/lib",
-      "@ledgerhq/react-ui>@ledgerhq/ui-shared": "../../packages/shared",
-      "@ledgerhq/react-ui>@ledgerhq/icons-ui": "../../packages/icons"
-    }
-  }'
-`;
-const rollbackPackageResolutions = `
-  pnpm json -I -f ./examples/${exampleName}/package.json -e 'delete this.pnpm'
-`;
-const prepareExample = `npm run clean:full && npm i --no-package-lock --legacy-peer-deps && npm run build`;
+const prepareExample = `pnpm clean:full && pnpm i --filter="${exampleName}-example" && pnpm build`;
 const runTest = `pnpm concurrently -s=first -k "pnpm --dir examples/${exampleName} serve" "playwright test ${
   UPDATE_SNAPSHOTS ? "--update-snapshots" : ""
 }"`;
 
 try {
-  child_process.execSync(addPackageResolutions, { stdio: "inherit" });
   child_process.execSync(prepareExample, {
     stdio: "inherit",
     cwd: `./examples/${exampleName}`,
   });
   child_process.execSync(runTest, { stdio: "inherit" });
-  child_process.execSync(rollbackPackageResolutions, { stdio: "inherit" });
 } catch (error) {
-  child_process.execSync(rollbackPackageResolutions, { stdio: "inherit" });
   console.error(error.message);
   process.exit(error.status);
 }
diff --git a/package.json b/package.json
@@ -16,8 +16,8 @@
     "changelog": "changeset add",
     "prerelease": "pnpm run build:libs",
     "release": "changeset publish",
-    "build:libs": "pnpm turbo build --no-daemon --filter=\"./libs/**\"",
-    "build:libs:force": "pnpm -r --filter=\"./libs/**\" build",
+    "build:libs": "pnpm turbo build --no-daemon --filter=\"./libs/**\" --filter=\"!./libs/ui/examples/**\"",
+    "build:libs:force": "pnpm -r --filter=\"./libs/**\" --filter=\"!./libs/ui/examples/**\" build",
     "build:actions": "pnpm turbo build --filter=@actions/*",
     "build:cli": "pnpm turbo build --no-daemon --filter=live-cli",
     "build:coin": "pnpm turbo build --no-daemon --filter=\"./libs/coin-**\"",
@@ -109,6 +109,8 @@
     "ui:icons": "pnpm --filter icons-ui",
     "ui:crypto-icons": "pnpm --filter crypto-icons-ui",
     "ui:shared": "pnpm --filter ui-shared",
+    "ui:example:next": "pnpm  --filter=\"next.js-example\"",
+    "ui:example:webpack": "pnpm  --filter=\"webpack.js-example\"",
     "actions": "pnpm --filter @actions/*"
   },
   "devDependencies": {