Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.10 to build workflow and fix upload jobs #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add python 3.10 to build workflow and fix upload jobs #20

wants to merge 2 commits into from

Conversation

wbarnha
Copy link

@wbarnha wbarnha commented Aug 2, 2022

I've had success using this library in Python 3.10, so it'd be appropriate to update it here.

@wbarnha wbarnha changed the title Add python 3.10 to build workflow Add python 3.10 to build workflow and fix upload jobs Aug 2, 2022
@wbarnha
Copy link
Author

wbarnha commented Aug 3, 2022

I have a fully operational pipeline in https://github.com/faust-streaming/python-rocksdb, in case further reference is sought. I haven't included all the changes since our repo is structured differently.

@wbarnha
Copy link
Author

wbarnha commented Aug 4, 2022

Something worth noting is that the wheels we uploaded onto PyPi are comically large (66 MB), other forks such as https://pypi.org/project/lbry-rocksdb/#files have managed to create smaller wheels. It'd be nice to understand why these wheels are so large. My initial thought was that something could've been included with librocksdb, but python-rocksdb will not work without librocksdb installed onto a machine.

Edit: I just realized this bundles librocksdb lol

@wbarnha wbarnha closed this Sep 19, 2022
@NightTsarina
Copy link
Owner

Hey, I am sorry I missed this completely! I even had some draft review of the PR but I never clicked send :(

@wbarnha
Copy link
Author

wbarnha commented Sep 20, 2022

No sweat, it happens! I'll reopen it for you.

@wbarnha wbarnha reopened this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants