Small KZGv2 placeholder test #300

NilFoundation · Mar 4, 2024 · a5da820 · a5da820
1 parent 585020c
commit a5da820
Show file tree

Hide file tree

Showing 3 changed files with 75 additions and 3 deletions.
diff --git a/include/nil/crypto3/zk/commitments/batched_commitment.hpp b/include/nil/crypto3/zk/commitments/batched_commitment.hpp
@@ -35,6 +35,7 @@
 #include <boost/property_tree/json_parser.hpp>
 
 #include <nil/crypto3/math/polynomial/polynomial_dfs.hpp>
+#include <nil/crypto3/math/polynomial/lagrange_interpolation.hpp>
 
 #include <nil/crypto3/zk/transcript/fiat_shamir.hpp>
 #include <nil/crypto3/zk/commitments/type_traits.hpp>
@@ -223,14 +224,14 @@ namespace nil {
                     void append_eval_points(std::size_t batch_id, std::set<typename field_type::value_type> points){
                         BOOST_ASSERT(_locked[batch_id]); // We can add points only after polynomails are commited.
                         for(std::size_t i = 0; i < _points[batch_id].size(); i++){
-                            _points[batch_id][i].insert(points.first(), points.last());
+                            _points[batch_id][i].insert(_points[batch_id][i].end(), points.begin(), points.end());
                         }
                     }
 
                     // This function don't check evaluation points repeats
                     void append_eval_points(std::size_t batch_id, std::size_t poly_id, std::set<typename field_type::value_type> points){
                         BOOST_ASSERT(_locked[batch_id]); // We can add points only after polynomails are commited.
-                        _points[batch_id][poly_id].insert(points.first(), points.last());
+                        _points[batch_id][poly_id].insert(_points[batch_id][poly_id].end(), points.begin(), points.end());
                     }
 
                     void set_batch_size(std::size_t batch_id, std::size_t batch_size){

diff --git a/include/nil/crypto3/zk/commitments/polynomial/kzg.hpp b/include/nil/crypto3/zk/commitments/polynomial/kzg.hpp
@@ -824,7 +824,14 @@ namespace nil {
 
                 };
 
-                // Placeholder-friendly class
+                // Placeholder-friendly class, KZGv2
+                /**
+                 * References:
+                 * "Efficient polynomial commitment schemes for
+                 * multiple points and polynomials",
+                 * Dan Boneh, Justin Drake, Ben Fisch,
+                 * <https://eprint.iacr.org/2020/081.pdf>
+                 */
                 template<typename KZGScheme, typename PolynomialType = typename math::polynomial_dfs<typename KZGScheme::field_type::value_type>>
                 class kzg_commitment_scheme_v2 : public polys_evaluator<typename KZGScheme::params_type, typename KZGScheme::commitment_type, PolynomialType>{
                 public:

diff --git a/test/commitment/kzg.cpp b/test/commitment/kzg.cpp
@@ -932,3 +932,67 @@ BOOST_AUTO_TEST_CASE(batched_kzg_placeholder_repr) {
 }
 
 BOOST_AUTO_TEST_SUITE_END()
+
+
+template<
+    typename curve_type,
+    typename transcript_hash_type
+    >
+struct placeholder_class_test_initializer {
+    bool run_test() {
+        typedef typename curve_type::scalar_field_type::value_type scalar_value_type;
+
+        using kzg_type = zk::commitments::batched_kzg<curve_type, transcript_hash_type>;
+        typedef typename kzg_type::transcript_type transcript_type;
+        using kzg_scheme_type = typename zk::commitments::kzg_commitment_scheme_v2<kzg_type>;
+
+        scalar_value_type alpha = 7;
+        auto params = typename kzg_type::params_type(8, 8, alpha);
+        kzg_scheme_type kzg(params);
+
+        typename kzg_type::batch_of_polynomials_type polys(4);
+
+        polys[0].template from_coefficients<std::vector<scalar_value_type>>({{ 1,  2,  3,  4,  5,  6,  7,  8}});
+        polys[1].template from_coefficients<std::vector<scalar_value_type>>({{11, 12, 13, 14, 15, 16, 17, 18}});
+        polys[2].template from_coefficients<std::vector<scalar_value_type>>({{21, 22, 23, 24, 25, 26, 27, 28}});
+        polys[3].template from_coefficients<std::vector<scalar_value_type>>({{31, 32, 33, 34, 35, 36, 37, 38}});
+
+
+        std::size_t batch_id = 0;
+
+        kzg.append_to_batch(batch_id, polys);
+        std::map<std::size_t, typename kzg_scheme_type::commitment_type> commitments;
+        commitments[batch_id] = kzg.commit(batch_id);
+
+        std::set<scalar_value_type> points_0 = {101, 2, 3};
+        std::set<scalar_value_type> points_1 = {102, 2, 3};
+        std::set<scalar_value_type> points_2 = {  1, 2, 3};
+        std::set<scalar_value_type> points_3 = {104, 2, 3};
+        kzg.append_eval_points(batch_id, 0, points_0);
+        kzg.append_eval_points(batch_id, 1, points_1);
+        kzg.append_eval_points(batch_id, 2, points_2);
+        kzg.append_eval_points(batch_id, 3, points_3);
+
+        transcript_type transcript;
+        auto proof = kzg.proof_eval(transcript);
+
+        transcript_type transcript_verification;
+        bool result = kzg.verify_eval(proof, commitments, transcript_verification);
+        return result;
+
+    }
+};
+
+BOOST_AUTO_TEST_SUITE(placeholder_class)
+    using TestFixtures = boost::mpl::list<
+        placeholder_class_test_initializer< algebra::curves::bls12_381, hashes::keccak_1600<256> >,
+        placeholder_class_test_initializer< algebra::curves::mnt4_298, hashes::keccak_1600<256> >,
+        placeholder_class_test_initializer< algebra::curves::mnt6_298, hashes::keccak_1600<256> >
+        >;
+
+BOOST_AUTO_TEST_CASE_TEMPLATE(placeholder_class_test, F, TestFixtures) {
+    F fixture;
+    BOOST_CHECK(fixture.run_test());
+}
+
+BOOST_AUTO_TEST_SUITE_END()