Optimize compilation #200
Open
Optimize compilation #200
+36
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyMlashkin
force-pushed
the
optimize_compilation
branch
from
0bbbc95 to
2c0292d
Compare
AndreyMlashkin
force-pushed
the
optimize_compilation
branch
from
0dafe88 to
254cc88
Compare
martun
reviewed
Dec 12, 2024
| @@ -22,7 +22,7 @@ jobs: | |||
| nix build -L .?#checks.x86_64-linux.crypto3-clang | |||
| env: | |||
| NIX_CONFIG: | | |||
| cores = 4 | |||
| cores = 16 | |||
There was a problem hiding this comment.
I see you were able to increase the number of cores. Did the memory usage decline after pre-compiled headers, and that allowed you to use more cores?
There was a problem hiding this comment.
Yes, exactly!
AndreyMlashkin
force-pushed
the
optimize_compilation
branch
from
01faa75 to
f4150eb
Compare
akokoshn
approved these changes
Dec 12, 2024
| @@ -22,17 +22,13 @@ jobs: | |||
| nix build -L .?#checks.x86_64-linux.crypto3-gcc | |||
| env: | |||
| NIX_CONFIG: | | |||
| cores = 4 | |||
| cores = 12 | |||
| @@ -26,6 +26,7 @@ target_include_directories(${CMAKE_WORKSPACE_NAME}_${CURRENT_PROJECT_NAME} INTER | |||
|
|
|||
| target_link_libraries(${CMAKE_WORKSPACE_NAME}_${CURRENT_PROJECT_NAME} INTERFACE | |||
| Boost::container | |||
| Boost::random | |||
There was a problem hiding this comment.
may be make sense link Boost librarie only to executable (proof-producer and tests), not for header only libraries?
But we can do it in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.