Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change component mockups names #220

Merged
merged 1 commit into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ namespace nil {

const std::size_t gates_amount = gates_amount_internal(this->witness_amount());
const std::size_t rows_amount = get_rows_amount(this->witness_amount());
const std::string component_name = "native_bls12_381_pairing";
const std::string component_name = "native_bls12_381_pairing_unfinished";

struct input_type {
std::array<var,2> P;
Expand Down
2 changes: 1 addition & 1 deletion include/nil/blueprint/component_mockups/comparison.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ namespace nil {

const std::size_t rows_amount = rows_amount_internal(this->witness_amount());
const std::size_t empty_rows_amount = get_empty_rows_amount();
const std::string component_name = "comparison";
const std::string component_name = "comparison_unfinished";


const std::size_t gate_instances = gate_instances_internal(this->witness_amount());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ namespace nil {

constexpr static const std::size_t gates_amount = 1;
const std::size_t rows_amount = get_rows_amount(this->witness_amount());
const std::string component_name = "non_native fp12 multiplication";
const std::string component_name = "non_native fp12 multiplication_unfinished";

struct input_type {
std::array<var,12> a;
Expand Down
2 changes: 1 addition & 1 deletion include/nil/blueprint/component_mockups/h2c.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ namespace nil {

constexpr static const std::size_t gates_amount = 0;
const std::size_t rows_amount = get_rows_amount(this->witness_amount());
const std::string component_name = "hash to curve";
const std::string component_name = "hash to curve unfinished";

using var = typename component_type::var;
using manifest_type = nil::blueprint::plonk_component_manifest;
Expand Down
2 changes: 1 addition & 1 deletion include/nil/blueprint/component_mockups/is_in_g1.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ namespace nil {

constexpr static const std::size_t gates_amount = 0;
const std::size_t rows_amount = get_rows_amount(this->witness_amount());
const std::string component_name = "is_in_g1";
const std::string component_name = "is_in_g1_unfinished";

using var = typename component_type::var;
using manifest_type = nil::blueprint::plonk_component_manifest;
Expand Down
2 changes: 1 addition & 1 deletion include/nil/blueprint/component_mockups/is_in_g2.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ namespace nil {

constexpr static const std::size_t gates_amount = 0;
const std::size_t rows_amount = get_rows_amount(this->witness_amount());
const std::string component_name = "is_in_g2";
const std::string component_name = "is_in_g2_unfinished";

using var = typename component_type::var;
using manifest_type = nil::blueprint::plonk_component_manifest;
Expand Down
6 changes: 2 additions & 4 deletions include/nil/blueprint/statistics.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,10 @@ namespace nil {

void add_record(std::string name, std::size_t rows, std::size_t gates, std::size_t witness) {

bool component_finished;
bool component_finished = true;

if (unfinished_components.find(name) != unfinished_components.end()) {
if (name.find("unfinished") != std::string::npos) {
component_finished = false;
} else {
component_finished = true;
}

if (components.find(name) == components.end()) {
Expand Down