fix: unwanted behaivour when byResource is not specified

NimmLor · Jun 14, 2023 · f1edd10 · f1edd10
1 parent bb74863
commit f1edd10
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -278,16 +278,13 @@ export class SelfDestructAspect implements IAspect {
       const att = node.getAtt('DeletionPolicy')
       if (
         att.displayName === 'DeletionPolicy' &&
-        this.settings.byResource?.resourcesToRetain?.includes(
-          node.cfnResourceType
-        ) === false &&
         shouldDestroy(
-          this.settings.byResource?.resourcesToDestroy?.includes(
-            node.cfnResourceType
-          ) === true
-            ? true
-            : undefined,
-          this.settings.defaultBehavior.destoryAllResources
+          undefined,
+          this.settings.defaultBehavior.destoryAllResources,
+          {
+            byResource: this.settings.byResource,
+            resourceName: node.cfnResourceType,
+          }
         ) &&
         node.cfnResourceType !== 'AWS::S3::Bucket'
       ) {