Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust by n-pixels added #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Slackow
Copy link

@Slackow Slackow commented Dec 15, 2024

With the n-pixel/fulleye strategy, it makes sense to be able to quickly adjust by a preset number of pixels (e.g 13).

I've added the following under the Angle adjustment menu:

Change the last angle by +n-pixels
Change the last angle by -n-pixels
n-pixels: (number)

This would prevent adjustment hotkeys from being needed to be pressed 10+ times when using these strategies, and allow for more accuracy when inputting these adjustments

Further, this strategy allows the user to have the same accuracy as tall resolution without making their window large, allowing it to be used on platforms that do not allow resizing the window past monitor bounds, like macOS

https://docs.google.com/document/d/1Yz6ORuSVBeQD53y6zn3TJQC1HZUj6QSqYxjIrBUrUHM/edit?tab=t.0

@Slackow
Copy link
Author

Slackow commented Feb 27, 2025

@Ninjabrain1 not sure who to contact for this but it'd be cool for this to be looked at cause it helps mac users with n-pixel

@Ninjabrain1
Copy link
Owner

Can this not already be achieved by using the "Custom adjustment" option?

@Ninjabrain1
Copy link
Owner

Hmm okay I see, you would have 4 hotkeys in use, 2 for regular increments and 2 for n?

@Slackow
Copy link
Author

Slackow commented Mar 7, 2025

@Ninjabrain1

Hmm okay I see, you would have 4 hotkeys in use, 2 for regular increments and 2 for n?

yes exactly, but I think a third toggleable option would also be useful, and that's to make the +-n keys act before recording the angle instead of after. That's because it can be used in conjunction with an OBS script that adjusts the horizontal position of the overlay to make it much easier to see the second (minor) adjustment. Here's an example video https://youtu.be/IeoQlCxMplI

This does complicate the code considerably, but I think It's a substantial enough upgrade for n-pixel users. I can post it as a separate pull request.

The reason the adjustment is before and not after is because you can't f3 + c while paused in f3 + esc, and with n-pixel you have to time the pause decently well (the bob of the eye matters) and verify that you are within two pixels of the position, and you'd otherwise need another 2 hotkeys, + double the keypresses to do the fancy OBS script thing shown in the video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants