Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memo rag notebook #74

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Memo rag notebook #74

wants to merge 11 commits into from

Conversation

erantr1
Copy link

@erantr1 erantr1 commented Jan 15, 2025

Added a notebook that outlines the MemoRAG technique and explains how MemoRAG works in principle.
Included an implementation of the workflow and a demonstration of the results on sample data.

@NirDiamant
Copy link
Owner

Hi!
very nice work.
several things to change/add:

  1. Please add documentation to the first cell of code of memory base classes
  2. please write a function that displays the results and use it in each of the examples (the code focuses maximally on understanding the logic)
  3. as this method uses external memory of the db and should get better results, it is crucial in this case to compare it with a vanilla RAG over the exact same queries (you can take the code from the basic tutorials in the repo)
    thanks!

@erantr1
Copy link
Author

erantr1 commented Jan 18, 2025

@NirDiamant

Going through the code again I realized it may return nice answers but the pipeline/workflow was not well-aligned with the paper. So I made some changes and now I think it's much better.

I also added documentation to the renewed Memory Class and I think I now have the function you asked for in section 2 (I'm not 100% I understood what you meant there, but if I did then it's solved).

I still need to add the comparison to vanilla RAG. Will do it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants