Merge remote-tracking branch 'skrat/master' into upstream-sept-24

# Conflicts:
#	.github/workflows/ci_suite.yml
#	_maps/skyrat/automapper/templates/metastation/metastation_armory.dmm
#	_maps/skyrat/lazy_templates/reebe.dmm
#	code/datums/quirks/negative_quirks/negative_quirks.dm
#	code/datums/quirks/neutral_quirks/neutral_quirks.dm
#	code/game/objects/items/robot/robot_upgrades.dm
#	code/modules/mining/equipment/kinetic_crusher.dm
#	code/modules/surgery/revival.dm
#	code/modules/uplink/uplink_items/device_tools.dm
#	modular_skyrat/modules/company_imports/code/armament_datums/bolt_nanotrasen_firearms.dm
#	modular_skyrat/modules/company_imports/code/armament_datums/deforest_medical.dm
#	modular_skyrat/modules/company_imports/code/armament_datums/nri_military_surplus.dm
#	modular_skyrat/modules/company_imports/code/armament_datums/put_a_donk_on_it.dm
#	modular_skyrat/modules/company_imports/code/armament_datums/vitezstvi_ammo.dm
#	modular_skyrat/modules/loadouts/loadout_items/donator/personal/donator_personal.dm
#	modular_skyrat/modules/player_ranks/code/subsystem/player_ranks.dm

.github/guides/MAPS_AND_AWAY_MISSIONS.md

@@ -1,17 +1,18 @@
 ## MAPS
 
-/tg/station currently has five station maps in rotation.
+/tg/station currently has six station maps in rotation.
+* [Birdshot](https://tgstation13.org/wiki/Birdshot)
 * [DeltaStation](https://tgstation13.org/wiki/DeltaStation)
 * [IceBoxStation](https://tgstation13.org/wiki/IceboxStation)
-* [KiloStation](https://tgstation13.org/wiki/KiloStation)
 * [MetaStation](https://tgstation13.org/wiki/MetaStation)
+* [NorthStar](https://tgstation13.org/wiki/The_North_Star)
 * [TramStation](https://tgstation13.org/wiki/Tramstation)
 
 Debug station maps.
 * [RuntimeStation](https://tgstation13.org/wiki/RuntimeStation)
 * [MultiZ](https://tgstation13.org/wiki/MultiZ)
 
-All maps have their own code file that is in the base of the `_maps` directory, or elsewhere in the codebase. For example, all of the station maps in rotation each have a corresponding JSON file and are loaded using `maps/_basemap.dm`. Maps are loaded dynamically when the game starts. Follow this guideline when adding your own map, to your fork, for easy compatibility.
+All maps have their own code file that is in the base of the `_maps` directory, or elsewhere in the codebase. For example, all of the station maps in rotation each have a corresponding JSON file and are loaded using the server's [configuration](#configuration) passed onto the Mapping subsystem. Maps are loaded dynamically when the game starts. Follow this guideline when adding your own map, to your fork, for easy compatibility.
 
 The map that will be loaded for the upcoming round is determined by reading `data/next_map.json`, which is a copy of the JSON files found in the `_maps` tree. If this file does not exist, the default map from `config/maps.txt` will be loaded. Failing that, MetaStation will be loaded. If you want to set a specific map to load next round you can use the Change Map verb in game before restarting the server or copy a JSON from `_maps` to `data/next_map.json` before starting the server. Also, for debugging purposes, ticking a corresponding map's code file in Dream Maker will force that map to load every round.
 

.github/workflows/ci_suite.yml

@@ -66,15 +66,7 @@ jobs:
           tools/bootstrap/python -m define_sanity.check
           tools/bootstrap/python -m dmi.test
           tools/bootstrap/python -m mapmerge2.dmm_test
-      - name: Output Annotations
-        if: success() || failure()
-        run: |
-          ~/dreamchecker > ${GITHUB_WORKSPACE}/output-annotations.txt 2>&1
-      - name: Process Annotations
-        uses: yogstation13/DreamAnnotate@v2
-        if: success() || failure()
-        with:
-          outputFile: output-annotations.txt
+          ~/dreamchecker 2>&1 | bash tools/ci/annotate_dm.sh
 
   compile_all_maps:
     if: "!contains(github.event.head_commit.message, '[ci skip]')"

.github/workflows/run_integration_tests.yml

@@ -63,7 +63,6 @@ jobs:
           tools/build/build --ci dm -DCIBUILDING -DANSICOLORS -WError -NWTG0001
       - name: Run Tests
         run: |
-          cp libbyond_sleeping_procs.so ~/.byond/bin/libbyond_sleeping_procs.so
           source $HOME/BYOND/byond/bin/byondsetup
           bash tools/ci/run_server.sh ${{ inputs.map }}
       - name: Upload screenshot tests

.gitignore

@@ -24,9 +24,6 @@
 # Ignore compiled linux libs in the root folder, e.g. librust_g.so
 /*.so
 
-# Remove when removing byond_status
-!/libbyond_sleeping_procs.so
-
 #Ignore compiled files and other files generated during compilation.
 *.mdme
 *.mdme.*

_maps/RandomRuins/IceRuins/skyrat/icemoon_underground_syndicate_base1_skyrat.dmm

@@ -1190,10 +1190,6 @@
 /obj/machinery/chem_master,
 /turf/open/floor/iron,
 /area/ruin/syndicate_lava_base/medbay)
-"jc" = (
-/obj/machinery/light/directional/east,
-/turf/open/floor/iron/dark,
-/area/ruin/syndicate_lava_base/bar)
 "jf" = (
 /obj/effect/turf_decal/vg_decals/department/bar{
 	dir = 1
@@ -4633,6 +4629,7 @@
 	dir = 8
 	},
 /obj/machinery/computer/security/telescreen/entertainment/directional/east,
+/obj/machinery/light/directional/east,
 /turf/open/floor/iron/dark,
 /area/ruin/syndicate_lava_base/bar)
 "Pc" = (
@@ -7386,7 +7383,7 @@ MT
 dR
 NY
 OV
-jc
+XT
 XT
 cZ
 xf

_maps/RandomRuins/LavaRuins/bubberstation/lavaland_dauntless.dmm

@@ -5695,7 +5695,7 @@
 /turf/open/floor/iron/dark/small,
 /area/ruin/space/has_grav/bubbers/dauntless/sec/prison)
 "DJ" = (
-/obj/structure/bed/roller,
+/obj/structure/bed/medical/emergency,
 /obj/effect/turf_decal/trimline/dark_blue/filled/line{
 	dir = 4
 	},
@@ -7184,7 +7184,9 @@
 /turf/open/floor/iron/white/textured_large,
 /area/ruin/space/has_grav/bubbers/dauntless/med/treatment)
 "Ks" = (
-/obj/machinery/recycler,
+/obj/machinery/recycler{
+	dir = 8
+	},
 /obj/machinery/conveyor{
 	id = "syndidisp";
 	dir = 4
@@ -9286,7 +9288,7 @@
 /obj/effect/turf_decal/trimline/dark_blue/filled/line{
 	dir = 6
 	},
-/obj/structure/bed/roller,
+/obj/structure/bed/medical/emergency,
 /obj/machinery/atmospherics/pipe/smart/manifold4w/scrubbers/hidden/layer2,
 /obj/machinery/atmospherics/pipe/smart/manifold4w/supply/hidden/layer4,
 /turf/open/floor/iron/white/diagonal,