[MANUAL MIRROR] Fix some reference leaks (#18818)

* Fix some reference leaks (#72669) For some reason, this repo doesn't have a problem with these references, but the downstream I work on catches these on the new 515 alternative GC test 100% of the time, despite us having not modifying these types. Go figure. Removed the tank var from the mister as it's basically unused except to leak a reference. Garbage collector happy Not player-facing Co-authored-by: Jeremiah <[email protected]> * Fixes the compile issue --------- Co-authored-by: Tastyfish <[email protected]> Co-authored-by: Jeremiah <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]>
NithaIsTired · Feb 3, 2023 · 63fd00c · 63fd00c
1 parent 5c01998
commit 63fd00c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/code/game/machinery/buttons.dm b/code/game/machinery/buttons.dm
@@ -50,9 +50,8 @@
 	setup_device()
 
 /obj/machinery/button/Destroy()
-	// Let them dump on the ground.
-	device = null
-	board = null
+	QDEL_NULL(device)
+	QDEL_NULL(board)
 	return ..()
 
 /obj/machinery/button/update_icon_state()

diff --git a/code/game/objects/items/tanks/watertank.dm b/code/game/objects/items/tanks/watertank.dm
@@ -131,18 +131,11 @@
 	item_flags = NOBLUDGEON | ABSTRACT  // don't put in storage
 	slot_flags = NONE
 
-	var/obj/item/watertank/tank
-
 /obj/item/reagent_containers/spray/mister/Initialize(mapload)
 	. = ..()
-	tank = loc
-	if(!tank?.reagents)
+	if(!loc?.reagents)
 		return INITIALIZE_HINT_QDEL
-	reagents = tank.reagents //This mister is really just a proxy for the tank's reagents
-
-/obj/item/reagent_containers/spray/mister/Destroy(force)
-	tank = null
-	return ..()
+	reagents = loc.reagents //This mister is really just a proxy for the tank's reagents
 
 /obj/item/reagent_containers/spray/mister/afterattack(obj/target, mob/user, proximity)
 	if(target.loc == loc) //Safety check so you don't fill your mister with mutagen or something and then blast yourself in the face with it