-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* fix sql perf / memory issue * fetch all states if found actions < maxActions * fix tests to compile * fix h2 sql syntax error and add test * avoid creating temp list * Fix @StateVar(instantiateIfNotExists=true) Mutable<Type> instantiation * fix formatting and typo and jdk8 compatibility Co-authored-by: Edvard Fonsell <[email protected]> Co-authored-by: Mikko Tiihonen <[email protected]>
- Loading branch information
3 people
authored
Dec 22, 2020
1 parent
b1ad83b
commit b1dfaa9
Showing
10 changed files
with
313 additions
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
nflow-engine/src/test/java/io/nflow/engine/internal/workflow/ObjectStringMapperTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| package io.nflow.engine.internal.workflow; | ||
|
|
||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.is; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import java.lang.reflect.Type; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
| import org.mockito.Mock; | ||
| import org.mockito.junit.jupiter.MockitoExtension; | ||
|
|
||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
|
|
||
| import io.nflow.engine.internal.workflow.WorkflowStateMethod.StateParameter; | ||
| import io.nflow.engine.workflow.definition.Mutable; | ||
| import io.nflow.engine.workflow.definition.StateExecution; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class ObjectStringMapperTest { | ||
|
|
||
| private final ObjectStringMapper mapper = new ObjectStringMapper(new ObjectMapper()); | ||
|
|
||
| @Mock | ||
| StateExecution execution; | ||
|
|
||
| @Test | ||
| public void stringRoundTrip() { | ||
| verifyRoundTrip(String.class, "test☃"); | ||
| } | ||
|
|
||
| @Test | ||
| public void longRoundTrip() { | ||
| verifyRoundTrip(Long.class, -1L); | ||
| } | ||
|
|
||
| private void verifyRoundTrip(Type type, Object value) { | ||
| String data = mapper.convertFromObject(null, value); | ||
| Object result = mapper.convertToObject(type, null, data); | ||
| assertThat(result, is(value)); | ||
| } | ||
|
|
||
| @Test | ||
| public void methodStringParam() { | ||
| verifyParam(String.class, "test€", "test€"); | ||
| } | ||
|
|
||
| @Test | ||
| public void methodLongParam() { | ||
| verifyParam(Long.class, "42", 42L); | ||
| } | ||
|
|
||
| @Test | ||
| public void methodPrimitiveIntParam() { | ||
| verifyParam(Integer.TYPE, "128", 0, 0, 128); | ||
| } | ||
|
|
||
| @Test | ||
| public void methodMutableLongParam() { | ||
| verifyParam(Long.class, "42", 0L, new Mutable<>(0L), new Mutable<>(42L)); | ||
| verifyParam(Long.class, "42", null, new Mutable<>(null), new Mutable<>(42L)); | ||
| } | ||
|
|
||
| private void verifyParam(Type type, String strVal, Object expectedVal) { | ||
| verifyParam(type, strVal, null, null, expectedVal); | ||
| } | ||
|
|
||
| private void verifyParam(Type type, String strVal, Object defaultVal, Object expectedDefautlVal, Object expectedVal) { | ||
| boolean mutable = expectedDefautlVal instanceof Mutable; | ||
| WorkflowStateMethod method = new WorkflowStateMethod(null, new StateParameter("null", type, defaultVal, false, mutable), | ||
| new StateParameter("key", type, defaultVal, false, mutable)); | ||
| when(execution.getVariable("null")).thenReturn(null); | ||
| when(execution.getVariable("key")).thenReturn(strVal); | ||
| Object[] vars = mapper.createArguments(execution, method); | ||
| assertThat(vars[1], is(expectedDefautlVal)); | ||
| assertThat(vars[2], is(expectedVal)); | ||
| } | ||
| } |
Oops, something went wrong.