Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python vault refactoring and code organization #528

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Python vault refactoring and code organization #528

merged 1 commit into from
Oct 8, 2024

Conversation

Esgrove
Copy link
Contributor

@Esgrove Esgrove commented Oct 8, 2024

Making a separate PR for my Python changes made when implementing the init and update for Rust.

  • In Vault.py, put private functions and methods after public. Change helper functions to static methods inside Vault class.
  • Encapsulate STATIC_IV as a static class member since it is not used outside the Vault class.
  • Make to_str public since it is used in the cli
  • Streamline vault initialization for init case and others

@Esgrove Esgrove requested a review from psiniemi October 8, 2024 09:07
@Esgrove Esgrove merged commit 9e34691 into master Oct 8, 2024
4 checks passed
@Esgrove Esgrove deleted the refactor branch October 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant