Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pin-info command #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add pin-info command #44

wants to merge 1 commit into from

Conversation

sosthene-nitrokey
Copy link
Contributor

FIx #39

Sample output:

$ ./hotp_verification pin-info
HOTP code verification application, version 1.6
...
Admin PIN counter: 8
User PIN Counter: 8
Operation success
$ HOTP code verification application, version 1.6
...
Admin PIN counter: Not set
User PIN Counter: Not set
Operation success

@tlaurion
Copy link
Contributor

@sosthene-nitrokey just want to make sure we are at the same page:

<nk3

HOTP code verification application, version 1.7
Connected device status:
Card serial: 0x7BE66C6C
         Firmware Nitrokey 2: v1.7.1
OpenPGP smartcard PIN counters : Admin: 3, User: 3
Operation success

nk3:

HOTP code verification application, version 1.7
Connected device status:
Card serial: 0x7BE66C6C
         Firmware Nitrokey 3: v1.7.1
         Firmware Secrets app: v4.13
Secret app PIN counter : 6
OpenPGP smartcard PIN counters : Admin: 3, User: 3
Operation success

Originally posted by @tlaurion in #38 (comment)

@sosthene-nitrokey
Copy link
Contributor Author

This is not the same command. This is pin-info, see #39 which is distinct from #38.

@tlaurion
Copy link
Contributor

This is not the same command. This is pin-info, see #39 which is distinct from #38.

I still see 2 pins instead of one secret app PIN?

@nestire
Copy link

nestire commented Nov 27, 2024

works with nk pro, nk stroage, nk3 mini, nk3.

Since this should only be used for parsing within heads to output it like that is actually better since it we don't need then different parsing for nk3

@tlaurion
Copy link
Contributor

I see two pins when there is only one still...

@tlaurion
Copy link
Contributor

tlaurion commented Dec 2, 2024

I repeat

You proposed :

See also issue #36
Change this:


HOTP code verification application, version 1.6
Connected device status:
	Card serial: 0x7BE66C6C
	Firmware: v4.13
	Card counters: Admin 6, User 6
Operation success

To

HOTP code verification application, version 1.6
Connected device status:
	Card serial: 0x7BE66C6C
        Firmware Nitrokey 3: v1.7.1
	Firmware Secrets app: v4.13
	Secret app pin counters : Admin 6, User 6
Operation success

I proposed and restated:

Even more sensical: no secret app even named anywhere because there is none on non nk3(regression), so no version of non existing secret app, no secret app pin, just real information :

HOTP code verification application, version 1.7
Connected device status:
Card serial: 0x7BE66C6C
         Firmware Nitrokey 2: v1.7.1
OpenPGP smartcard PIN counters : Admin: 3, User: 3
Operation success

For nk3:

HOTP code verification application, version 1.7
Connected device status:
Card serial: 0x7BE66C6C
         Firmware Nitrokey 3: v1.7.1
         Firmware Secrets app: v4.13
Secret app PIN counter : 6
OpenPGP smartcard PIN counters : Admin: 3, User: 3
Operation success

Originally posted by @tlaurion in #38 (comment)

@sosthene-nitrokey
Copy link
Contributor Author

That's relevant for #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cli option to request secret app admin/user pin counts
3 participants