Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #100

Merged
merged 8 commits into from
Aug 18, 2023
Merged

Update documentation #100

merged 8 commits into from
Aug 18, 2023

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented Aug 12, 2023

Add design document.
Refresh CTAPHID and protocol docs.

Fixes #98

@szszszsz szszszsz force-pushed the update-documentation branch 2 times, most recently from fe7ae68 to 48a5d25 Compare August 12, 2023 17:45
Base automatically changed from 65-update-credential-2 to main August 18, 2023 13:05
@szszszsz szszszsz marked this pull request as ready for review August 18, 2023 13:13
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe mention that the overwrite protection can leak information about the presence of a PIN-encrypted credential.

@szszszsz
Copy link
Member Author

szszszsz commented Aug 18, 2023

Looks good. Maybe mention that the overwrite protection can leak information about the presence of a PIN-encrypted credential.

If this is a real concern, then I can address it in the next release.

Registered as: #101

@szszszsz szszszsz merged commit 210e8ec into main Aug 18, 2023
2 checks passed
@szszszsz szszszsz deleted the update-documentation branch August 18, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add design document
2 participants