Add changelog entry, disable symbol resolution by default

NixOS · Oct 20, 2024 · b6c291b · b6c291b
1 parent 65efe86
commit b6c291b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@
 
 ### Added
 
+- Experimental support for resolving variables.
+  The feature is disabled by default since the functionality is rather limited for now.
+  Feel free to comment your feedback at [issue #87](https://github.com/NixOS/nix-idea/issues/87).
+
 ### Changed
 
 ### Deprecated

diff --git a/src/main/java/org/nixos/idea/settings/NixSymbolSettings.kt b/src/main/java/org/nixos/idea/settings/NixSymbolSettings.kt
@@ -11,7 +11,7 @@ import org.nixos.idea.settings.SimplePersistentStateComponentHelper.delegate
 class NixSymbolSettings : SimplePersistentStateComponent<NixSymbolSettings.State>(State()) {
 
     class State : BaseState() {
-        var enabled by property(true)
+        var enabledPreview by property(false)
         var jumpToFirstDeclaration by property(false)
         var showDeclarationsAsUsages by property(false)
     }
@@ -23,7 +23,7 @@ class NixSymbolSettings : SimplePersistentStateComponent<NixSymbolSettings.State
         }
     }
 
-    var enabled: Boolean by delegate(State::enabled)
+    var enabled: Boolean by delegate(State::enabledPreview)
     var jumpToFirstDeclaration by delegate(State::jumpToFirstDeclaration)
     var showDeclarationsAsUsages: Boolean by delegate(State::showDeclarationsAsUsages)
 

diff --git a/src/test/java/org/nixos/idea/lang/references/AbstractSymbolNavigationTests.kt b/src/test/java/org/nixos/idea/lang/references/AbstractSymbolNavigationTests.kt
@@ -96,6 +96,7 @@ abstract class AbstractSymbolNavigationTests {
         val declarationMarkers = markers.markers(TAG_DECL)
         val referenceMarkers = markers.markers(TAG_REF)
 
+        NixSymbolSettings.getInstance().enabled = true
         val file = myFixture.configureByText(NixFileType.INSTANCE, unmarkedCode)
         PsiTestUtil.checkErrorElements(file) // Fail early if there is a syntax error