Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade README to require at least JDK 17 #88

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

Avanatiker
Copy link
Contributor

This change updates the project's requirements to mandate at least JDK 17. The primary reason is compatibility with the intellij-platform-gradle-plugin version 2.0.1, which is built for Java 17.

Attempts to resolve dependencies with Java 11 fail due to compatibility issues, as the plugin's apiElements and runtimeElements require Java 17. Additionally, Gradle features used by the plugin, such as org.gradle.plugin.api-version=8.6, further necessitate upgrading the JDK.

@JojOatXGME
Copy link
Contributor

Thanks for your contribution. You indeed need Java 17 to build the project. We even use Java 17 ourselves, not only for dependencies.

Anyway, there seems to be some problem with the build. Shouldn't have anything to do with your changes. 😄 Here is a link to the build. I am wondering if the error is caused by gradle/actions/setup-gradle@v3. I switched to this action earlier this year. I will take a look.

FAILURE: Build failed with an exception.

* Where:
Initialization script '/home/runner/work/_temp/dummy-cleanup-project/init.gradle' line: 8

* What went wrong:
Cannot get the value of write-only property 'removeUnusedEntriesOlderThan' for object of type org.gradle.api.internal.cache.DefaultCacheConfigurations$DefaultCacheResourceConfiguration.

@JojOatXGME
Copy link
Contributor

JojOatXGME commented Dec 7, 2024

I have fixed the issue with the build in 64602c0. I also rebased your PR to make the build work. Afterward, I realized that rebasing the branch of someone else's PR is probably not the wisest action 😅.

I would merge the PR if you don't have any objections.

@Avanatiker
Copy link
Contributor Author

Haha its ok! Also looks good to me 🐱 start the merge 🚂 ❄️

@JojOatXGME JojOatXGME merged commit 49af7b9 into NixOS:master Jan 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants