Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpd/pocket-4: init #1317

Merged
merged 1 commit into from
Jan 20, 2025
Merged

gpd/pocket-4: init #1317

merged 1 commit into from
Jan 20, 2025

Conversation

miangraham
Copy link
Contributor

@miangraham miangraham commented Jan 16, 2025

Description of changes

Here's a Pocket 4 first pass based on the Pocket 3 setup.

I'm testing this on the Pocket 4 with AI 9 HX 370 using NixOS 24.11 and mainline kernel 6.12. Apart from the display rotation needed in kernel params and WM settings like the Pocket 3, basic desktop stuff seems to just work.

Verified so far:

  • Audio
  • Bluetooth
  • Camera: Works. Tested in OBS
  • Display: Built-in screen is on and oriented properly in stage-1 before LUKS passphrase. Sway requires WM-side rotation, not sure about other GUI envs.
  • DisplayPort over USB-C: Works
  • HDMI: Works. Auto-detects on hotplug and comes back after suspend. On in time for passphrase.
  • Internet via RJ45
  • MicroSD reader module: Works.
  • Mouse: Built-in touchpad and click buttons work fine.
  • P-States enabled, EPP settings available
  • Suspend and resume (systemctl suspend with default BIOS)
  • Touchscreen: Works
  • USB ports: All working
  • Video: Hardware decoding in mpv and chrome
  • Wifi

Not working:

❌ Fingerprint Reader: HOLTEK FocalTech Fingerprint Device. No driver support yet. Places to watch: 1, 2

Untested:

❓ Optional hardware modules (KVM, serial, LTE). I don't have any of these to try out. YMMV.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@miangraham miangraham force-pushed the gpd-pocket-4-init branch 3 times, most recently from 9b66a2a to 99a69fb Compare January 16, 2025 06:40
@miangraham miangraham marked this pull request as ready for review January 16, 2025 06:45
@miangraham
Copy link
Contributor Author

Should be good to go! System's working great.

Copy link
Contributor

@LucasFA LucasFA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the hardware to test this, but seems like an interesting computer. My suggestions are based purely on the specs.

gpd/pocket-4/default.nix Outdated Show resolved Hide resolved
gpd/pocket-4/default.nix Outdated Show resolved Hide resolved
gpd/pocket-4/default.nix Outdated Show resolved Hide resolved
gpd/pocket-4/default.nix Show resolved Hide resolved
@miangraham
Copy link
Contributor Author

P-States flipped on and briefly tested. I don't have the cycles to do extended power investigation, but they're enabled and not hurting anything. Quick results with otherwise default settings:

$ dmesg | grep "Kernel command line"
[    0.041247] Kernel command line: initrd=\EFI\nixos\g219bvi25xmzhv2qjx5wxa6n2w0342hw-initrd-linux-6.12.9-initrd.efi init=/nix/store/mhwmka1j2wrr8cwvd5nic6qma20zl20c-nixos-system-yuuri-24.11.20250115.e24b4c0/init amd_pstate=active fbcon=rotate:1 video=eDP-1:panel_orientation=right_side_up loglevel=4

$ cat /sys/firmware/acpi/platform_profile_choices
low-power balanced performance

$ cat /sys/firmware/acpi/platform_profile
balanced

$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_governors
performance powersave

$ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
powersave

$ cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_available_preferences
default performance balance_performance balance_power power

$ cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference
balance_power

Not sure why there's no schedutil governor. Kernel support maybe not there yet? powersave geekbenches at 4% below performance with 0.2W idle battery draw savings, which seems perfectly reasonable as a default so no governor changes made here.

@miangraham miangraham requested a review from LucasFA January 17, 2025 02:23
@Mic92
Copy link
Member

Mic92 commented Jan 19, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Jan 19, 2025

queue

☑️ The pull request will automatically be requeued

Merge queue reset: an external action moved the base branch head to cb3173d

mergify bot added a commit that referenced this pull request Jan 19, 2025
mergify bot added a commit that referenced this pull request Jan 19, 2025
@Mic92 Mic92 merged commit c3e369b into NixOS:master Jan 20, 2025
3 checks passed
@Mic92
Copy link
Member

Mic92 commented Jan 20, 2025

@mergify refresh

Copy link
Contributor

mergify bot commented Jan 20, 2025

refresh

✅ Pull request refreshed

@Mic92
Copy link
Member

Mic92 commented Jan 20, 2025

@mergify dequeue

Copy link
Contributor

mergify bot commented Jan 20, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #1317 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 20, 2025

dequeue

✅ The pull request has been removed from the queue default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants