Add responsive footer element #1122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfc
commented
Sep 16, 2023
| --- | ||
|
|
||
| <footer> | ||
| Footer | ||
| <style> | ||
| .nixlogo { |
There was a problem hiding this comment.
not sure what's the best way to do this. The good part about this is that it is defined in the same file as it's used. but if we need this svg somewhere else too, we would need a more central place.
Of course, it could also just be an tag that links to an svg file... not sure why it is like this in the original nixos.org implementation?
There was a problem hiding this comment.
I think we should create a custom icon set as described in astro-icon.
thilobillerbeck
approved these changes
Sep 17, 2023
|
looks good 👍 since this is already in main, there is no need to merge imo |
|
@tfc awesome to have so quick turn around. I've protected the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the meeting, this is my attempt to mimic the original footer of nixos.org, but described with tailwind CSS.
ref #1125