postfixadmin: use best practices, don't use pname in fetchFromGitHub

NixOS · Dec 6, 2024 · 1f51ab8 · 1f51ab8
1 parent b1ed089
commit 1f51ab8
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/pkgs/by-name/po/postfixadmin/package.nix b/pkgs/by-name/po/postfixadmin/package.nix
@@ -5,14 +5,14 @@
   fetchpatch2,
   nixosTests,
 }:
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "postfixadmin";
   version = "3.3.14";
 
   src = fetchFromGitHub {
-    owner = pname;
-    repo = pname;
-    rev = "${pname}-${version}";
+    owner = "postfixadmin";
+    repo = "postfixadmin";
+    rev = "refs/tags/postfixadmin-${finalAttrs.version}";
     sha256 = "sha256-T7KRD0ihtWcvJB6pZxXThFHerL5AGd8+mCg8UIXPZ4g=";
   };
 
@@ -24,6 +24,8 @@ stdenv.mkDerivation rec {
     })
   ];
 
+  strictDeps = true;
+
   installPhase = ''
     mkdir $out
     cp -r * $out/
@@ -40,4 +42,4 @@ stdenv.mkDerivation rec {
     license = lib.licenses.gpl2Plus;
     platforms = lib.platforms.all;
   };
-}
+})