Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chromium: resolve ref to rev for blink version string
This allows us to match the version the binaries use more closely. For example, chromedriver darwin (binary) reports the following: ~~~bash chromedriver --version ChromeDriver 131.0.6778.85 (3d81e41b6f3ac8bcae63b32e8145c9eb0cd60a2d-refs/branch-heads/6778@{#2285}) ~~~ while on Linux, where we build chromedriver based on the chromium derivation from source and control the string ourselves: ~~~bash chromedriver --version ChromeDriver 131.0.6778.85 (131.0.6778.85-refs/heads/master@{#0}) ~~~ With this commit, the version string now reports: ~~~bash chromedriver --version ChromeDriver 131.0.6778.85 (3d81e41b6f3ac8bcae63b32e8145c9eb0cd60a2d-refs/tags/131.0.6778.85@{#0}) ~~~ This may seem like a small and unimportant detail, but turns out an internal function within chromedriver depends on the git hash. See https://chromium.googlesource.com/chromium/src/+/131.0.6778.85/chrome/test/chromedriver/chrome/browser_info.cc#172 This caused the tests of one package (single-file-cli) that use selenium with chromium and chromedriver to fail in 24.05. Only in 24.05, because 24.11 and unstable removed their test dependency on chromedriver because it wasn't available for aarch64-linux at that time. ~~~ Running phase: checkPhase Serving HTTP on 127.0.0.1 port 8000 (http://127.0.0.1:8000/) ... session not created from unknown error: unrecognized Blink revision: 131.0.6778.85 URL: http://127.0.0.1:8000 Stack: SessionNotCreatedError: session not created from unknown error: unrecognized Blink revision: 131.0.6778.85 at Object.throwDecodedError (/build/source/node_modules/selenium-webdriver/lib/error.js:524:15) at parseHttpResponse (/build/source/node_modules/selenium-webdriver/lib/http.js:601:13) at Executor.execute (/build/source/node_modules/selenium-webdriver/lib/http.js:529:28) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) ~~~ (cherry picked from commit 2a765df)
- Loading branch information