Incorporate feedback

- move maturingBuildHook to build-system - use pkgs.krb5
NixOS · Dec 24, 2024 · 9873b85 · 9873b85
1 parent 4d03c1a
commit 9873b85
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/pkgs/development/python-modules/connectorx/default.nix b/pkgs/development/python-modules/connectorx/default.nix
@@ -1,10 +1,13 @@
-{ lib, buildPythonPackage, rustPlatform, pytestCheckHook,
-
-fetchFromGitHub,
-
-krb5, openssl,
-
-libkrb5, }:
+{ lib
+, buildPythonPackage
+, rustPlatform
+, pytestCheckHook
+, fetchFromGitHub
+, krb5-c
+, openssl
+, libkrb5
+,
+}:
 buildPythonPackage rec {
   pname = "connectorx";
   version = "0.3.3";
@@ -32,11 +35,14 @@ buildPythonPackage rec {
     OPENSSL_DIR = "${lib.getDev openssl}";
   };
 
+  build-system = [
+    rustPlatform.maturinBuildHook
+  ];
+
   nativeBuildInputs = [
-    krb5 # needed for `krb5-config` during libgssapi-sys
+    krb5-c # needed for `krb5-config` during libgssapi-sys
 
     rustPlatform.cargoSetupHook
-    rustPlatform.maturinBuildHook
     rustPlatform.bindgenHook
   ];
 

diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
@@ -2065,7 +2065,9 @@ self: super: with self; {
 
   connection-pool = callPackage ../development/python-modules/connection-pool { };
 
-  connectorx = callPackage ../development/python-modules/connectorx {};
+  connectorx = callPackage ../development/python-modules/connectorx {
+    krb5-c = pkgs.krb5;
+  };
 
   connio = callPackage ../development/python-modules/connio { };