octave: Do not --enable-link-all-dependencies on Darwin

It seems like upstream Octave removed the requirement that Darwin
default to linking all of its dependencies[1]. Some packages (ltfat)
cannot link against Octave for some reason. Removing this optinal
configure flag fixes this issue.

[1] gnu-octave/octave@d4479bd

pkgs/development/interpreters/octave/build-octave-package.nix

@@ -123,10 +123,6 @@ stdenv.mkDerivation (
       else
         preBuild;
 
-    # Add Octave's shared objects to ld library path for some packages which
-    # need to link their C/C++/Fortran code against Octave's internals.
-    LD_LIBRARY_PATH = lib.makeLibraryPath nativeBuildInputs';
-
     buildPhase = ''
       runHook preBuild
 

pkgs/development/interpreters/octave/default.nix

@@ -183,7 +183,6 @@ stdenv.mkDerivation (finalAttrs: {
       "--with-lapack=lapack"
       (if use64BitIdx then "--enable-64" else "--disable-64")
     ]
-    ++ lib.optionals stdenv.hostPlatform.isDarwin [ "--enable-link-all-dependencies" ]
     ++ lib.optionals enableReadline [ "--enable-readline" ]
     ++ lib.optionals stdenv.hostPlatform.isDarwin [ "--with-x=no" ]
     ++ lib.optionals enableQt [ "--with-qt=5" ];