Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oraclejdk8: remove dependency on libav #111528

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

bbjubjub2494
Copy link
Member

@bbjubjub2494 bbjubjub2494 commented Feb 1, 2021

Motivation for this change

Avoid oraclejdk being flagged as insecure after #111330. Affects oraclejdk8, oraclejdk11, oraclejdk14. This needs more testing, but a priori, libav is not actually needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Feb 1, 2021
@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review February 1, 2021 08:56
@bbjubjub2494 bbjubjub2494 changed the title oraclejdk: remove dependency on libav oraclejdk8: remove dependency on libav Feb 1, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111528 run on x86_64-linux 1

6 packages failed to build and already failed to build on hydra master:
  • docear: log was empty
  • jrePlugin: log was empty
  • oraclejdk: log was empty
  • oraclejre: log was empty
  • processing: log was empty
  • sqldeveloper: log was empty
6 packages failed to build and are new build failures:
  • ib-controller: log was empty
  • ib-tws: log was empty
  • javacard-devkit: log was empty
  • (jre8Plugin): log was empty
  • (oraclejdk8): log was empty
  • (oraclejre8): log was empty

@SuperSandro2000 SuperSandro2000 merged commit 5cbe469 into NixOS:master Feb 1, 2021
@bbjubjub2494 bbjubjub2494 deleted the oraclejdk_no_libav branch February 1, 2021 14:58
@bbjubjub2494 bbjubjub2494 mentioned this pull request Feb 1, 2021
12 tasks
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants