Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signumone-ks: removing libav_0_8 #111693

Merged
merged 1 commit into from
Feb 3, 2021
Merged

signumone-ks: removing libav_0_8 #111693

merged 1 commit into from
Feb 3, 2021

Conversation

WolfangAukang
Copy link
Contributor

Motivation for this change

Based on #111330.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WolfangAukang WolfangAukang mentioned this pull request Feb 3, 2021
Merged
12 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 3, 2021
@dotlambda
Copy link
Member

As mentioned in #108191 (comment), it seems like you should rather remove ffmpeg.

dotlambda
dotlambda approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it seems like the binaries refer to every possible version of libavcodec and libavformat:

autoPatchelfHook could not satisfy dependency libavcodec-ffmpeg.so.56 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so
autoPatchelfHook could not satisfy dependency libavcodec.so.58 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-58.so
autoPatchelfHook could not satisfy dependency libavcodec.so.53 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so
autoPatchelfHook could not satisfy dependency libavcodec.so.57 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so
autoPatchelfHook could not satisfy dependency libavcodec.so.56 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so
autoPatchelfHook could not satisfy dependency libavcodec.so.55 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so
autoPatchelfHook could not satisfy dependency libavcodec.so.54 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so
autoPatchelfHook could not satisfy dependency libavformat-ffmpeg.so.56 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so
autoPatchelfHook could not satisfy dependency libasound.so.2 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libjsoundalsa.so
autoPatchelfHook could not satisfy dependency libavformat.so.58 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-58.so
autoPatchelfHook could not satisfy dependency libavformat.so.54 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so
autoPatchelfHook could not satisfy dependency libavformat.so.55 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so
autoPatchelfHook could not satisfy dependency libavformat.so.56 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so
autoPatchelfHook could not satisfy dependency libavformat.so.57 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so
autoPatchelfHook could not satisfy dependency libavformat.so.53 wanted by /nix/store/2a2rvzsjl2kb16a28i6xgycw45k054p9-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so

Hence I assume they are compatible with any version.

@dotlambda dotlambda merged commit e7288c3 into NixOS:master Feb 3, 2021
@WolfangAukang WolfangAukang deleted the signumone-ks-remove_libav branch August 12, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WolfangAukang @dotlambda