Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] python3Packages.poetry*: fixes #120086

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 21, 2021

Motivation for this change

Looks like nix-update picked up a pre-release, and I didn't do enough testing on the previous PR

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Jonathan Ringer added 3 commits April 21, 2021 09:19
@jonringer jonringer requested a review from FRidh as a code owner April 21, 2021 16:39
@jonringer jonringer changed the title python3Packages.poetry*: fixes [staging-next] python3Packages.poetry*: fixes Apr 21, 2021
@ofborg ofborg bot requested a review from jbaum98 April 21, 2021 16:49
@mweinelt
Copy link
Member

mweinelt commented Apr 21, 2021

https://github.com/python-poetry/poetry-core/releases/tag/1.1.0a3

Clearly marked as pre-release, but the release atom feed does not seem to reflect that.

<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/" xml:lang="en-US">
  <id>tag:github.com,2008:https://github.com/python-poetry/poetry-core/releases</id>
  <link type="text/html" rel="alternate" href="https://github.com/python-poetry/poetry-core/releases"/>
  <link type="application/atom+xml" rel="self" href="https://github.com/python-poetry/poetry-core/releases.atom"/>
  <title>Release notes from poetry-core</title>
  <updated>2021-04-09T15:37:58Z</updated>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.1.0a3</id>
    <updated>2021-04-09T15:49:33Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.1.0a3"/>
    <title>1.1.0a3</title>
    <content type="html">&lt;h3&gt;Fixed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Fixed dependency markers not being properly copied when changing the constraint (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/162&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/162/hovercard&quot;&gt;#162&lt;/a&gt;).&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.0.3</id>
    <updated>2021-04-09T15:45:11Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.0.3"/>
    <title>1.0.3</title>
    <content type="html">&lt;h3&gt;Fixed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Fixed an error when handling single-digit Python markers (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/156&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/156/hovercard&quot;&gt;#156&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed dependency markers not being properly copied when changing the constraint (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/163&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/163/hovercard&quot;&gt;#163&lt;/a&gt;).&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.1.0a2</id>
    <updated>2021-04-08T15:57:30Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.1.0a2"/>
    <title>1.1.0a2</title>
    <content type="html">&lt;h3&gt;Fixed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Fixed performance regressions when parsing version constraints (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/152&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/152/hovercard&quot;&gt;#152&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed how local build versions are handled and compared (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/157&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/157/hovercard&quot;&gt;#157&lt;/a&gt;, &lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/158&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/158/hovercard&quot;&gt;#158&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed errors when parsing some environment markers (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/155&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/155/hovercard&quot;&gt;#155&lt;/a&gt;).&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.1.0a1</id>
    <updated>2021-03-30T15:21:27Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.1.0a1"/>
    <title>1.1.0a1</title>
    <content type="html">&lt;p&gt;This version is the first to drop support for Python 2.7 and 3.5.&lt;/p&gt;
&lt;p&gt;If you are still using these versions you should update the &lt;code&gt;requires&lt;/code&gt; property of the &lt;code&gt;build-system&lt;/code&gt; section&lt;br&gt;
to restrict the version of &lt;code&gt;poetry-core&lt;/code&gt;:&lt;/p&gt;
&lt;div class=&quot;highlight highlight-source-toml&quot;&gt;&lt;pre&gt;[&lt;span class=&quot;pl-en&quot;&gt;build-system&lt;/span&gt;]
&lt;span class=&quot;pl-smi&quot;&gt;requires&lt;/span&gt; = [&lt;span class=&quot;pl-s&quot;&gt;&lt;span class=&quot;pl-pds&quot;&gt;&quot;&lt;/span&gt;poetry-core&amp;lt;1.1.0&lt;span class=&quot;pl-pds&quot;&gt;&quot;&lt;/span&gt;&lt;/span&gt;]
&lt;span class=&quot;pl-smi&quot;&gt;build-backend&lt;/span&gt; = &lt;span class=&quot;pl-s&quot;&gt;&lt;span class=&quot;pl-pds&quot;&gt;&quot;&lt;/span&gt;poetry.core.masonry.api&lt;span class=&quot;pl-pds&quot;&gt;&quot;&lt;/span&gt;&lt;/span&gt;&lt;/pre&gt;&lt;/div&gt;
&lt;h3&gt;Changed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Dropped support for Python 2.7 and 3.5 (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/131&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/131/hovercard&quot;&gt;#131&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Reorganized imports internally to improve performances (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/131&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/131/hovercard&quot;&gt;#131&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Directory dependencies are now in non-develop mode by default (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/98&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/98/hovercard&quot;&gt;#98&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Improved support for PEP 440 specific versions that do not abide by semantic versioning (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/140&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/140/hovercard&quot;&gt;#140&lt;/a&gt;).&lt;/li&gt;
&lt;/ul&gt;
&lt;h3&gt;Fixed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Fixed path dependencies PEP 508 representation (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/141&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/141/hovercard&quot;&gt;#141&lt;/a&gt;).&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.0.2</id>
    <updated>2021-02-05T20:24:14Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.0.2"/>
    <title>1.0.2</title>
    <content type="html">&lt;h3&gt;Fixed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Fixed a missing import causing an error in Poetry (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/134&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/134/hovercard&quot;&gt;#134&lt;/a&gt;).&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.0.1</id>
    <updated>2021-02-05T19:54:21Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.0.1"/>
    <title>1.0.1</title>
    <content type="html">&lt;h3&gt;Fixed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Fixed PEP 508 representation of dependency without extras (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/102&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/102/hovercard&quot;&gt;#102&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed an error where development dependencies were being resolved when invoking the PEP-517 backend (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/101&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/101/hovercard&quot;&gt;#101&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed source distribution not being deterministic (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/105&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/105/hovercard&quot;&gt;#105&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed an error where zip files were left open when building wheels (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/122&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/122/hovercard&quot;&gt;#122&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed an error where explicitly included files were still not present in final distributions (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/124&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/124/hovercard&quot;&gt;#124&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed wheel filename matching for recent architecture (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/125&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/125/hovercard&quot;&gt;#125&lt;/a&gt;, &lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/129&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/129/hovercard&quot;&gt;#129&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed an error where the &lt;code&gt;&amp;amp;&lt;/code&gt; character was not accepted for author names (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/120&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/120/hovercard&quot;&gt;#120&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed the PEP-508 representation of some dependencies (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/103&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/103/hovercard&quot;&gt;#103&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed the &lt;code&gt;Requires-Python&lt;/code&gt; metadata generation (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/127&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/127/hovercard&quot;&gt;#127&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed an error where pre-release versions were accepted in version constraints (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/128&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/128/hovercard&quot;&gt;#128&lt;/a&gt;).&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.0.0</id>
    <updated>2020-09-30T23:13:50Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.0.0"/>
    <title>1.0.0</title>
    <content>No content.</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.0.0rc3</id>
    <updated>2020-09-30T20:36:22Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.0.0rc3"/>
    <title>1.0.0rc3</title>
    <content type="html">&lt;h3&gt;Changed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Removed &lt;code&gt;intreehooks&lt;/code&gt; build backend in favor of the &lt;code&gt;backend-path&lt;/code&gt; mechanism (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/90&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/90/hovercard&quot;&gt;#90&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Directory dependencies will now always use a posix path for their representation (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/91&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/91/hovercard&quot;&gt;#90&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Dependency constraints can now be set directly via a proper setter (&lt;a href=&quot;https://github.com/python-poetry/poetry-core/pull/90&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/90/hovercard&quot;&gt;#90&lt;/a&gt;).&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.0.0rc2</id>
    <updated>2020-09-25T13:41:45Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.0.0rc2"/>
    <title>1.0.0rc2</title>
    <content>No content.</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/238972646/1.0.0rc1</id>
    <updated>2020-09-25T10:55:37Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/python-poetry/poetry-core/releases/tag/1.0.0rc1"/>
    <title>1.0.0rc1</title>
    <content type="html">&lt;h3&gt;Fixed&lt;/h3&gt;
&lt;ul&gt;
&lt;li&gt;Fixed Python constraint propagation when converting a package to a dependency (&lt;a href=&quot;https://github.com/python-poetry/core/pull/84&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/84/hovercard&quot;&gt;#84&lt;/a&gt;).&lt;/li&gt;
&lt;li&gt;Fixed VCS ignored files being included in wheel distributions for projects using the &lt;code&gt;src&lt;/code&gt; layout (&lt;a href=&quot;https://github.com/python-poetry/core/pull/81&quot; data-hovercard-type=&quot;pull_request&quot; data-hovercard-url=&quot;/python-poetry/poetry-core/pull/81/hovercard&quot;&gt;#81&lt;/a&gt;)&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>sdispater</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/555648?s=60&amp;v=4"/>
  </entry>
</feed>

https://github.com/python-poetry/poetry-core/releases.atom

There is a better api endpoint that we already use in the home-assistant update script.

{
  "url": "https://api.github.com/repos/python-poetry/poetry-core/releases/41192682",
  "assets_url": "https://api.github.com/repos/python-poetry/poetry-core/releases/41192682/assets",
  "upload_url": "https://uploads.github.com/repos/python-poetry/poetry-core/releases/41192682/assets{?name,label}",
  "html_url": "https://github.com/python-poetry/poetry-core/releases/tag/1.0.3",
  "id": 41192682,
  "author": {
    "login": "sdispater",
    "id": 555648,
    "node_id": "MDQ6VXNlcjU1NTY0OA==",
    "avatar_url": "https://avatars.githubusercontent.com/u/555648?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/sdispater",
    "html_url": "https://github.com/sdispater",
    "followers_url": "https://api.github.com/users/sdispater/followers",
    "following_url": "https://api.github.com/users/sdispater/following{/other_user}",
    "gists_url": "https://api.github.com/users/sdispater/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/sdispater/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/sdispater/subscriptions",
    "organizations_url": "https://api.github.com/users/sdispater/orgs",
    "repos_url": "https://api.github.com/users/sdispater/repos",
    "events_url": "https://api.github.com/users/sdispater/events{/privacy}",
    "received_events_url": "https://api.github.com/users/sdispater/received_events",
    "type": "User",
    "site_admin": false
  },
  "node_id": "MDc6UmVsZWFzZTQxMTkyNjgy",
  "tag_name": "1.0.3",
  "target_commitish": "01c0472d9cef3e1a4958364122dd10358a9bd719",
  "name": "1.0.3",
  "draft": false,
  "prerelease": false,
  "created_at": "2021-04-09T15:33:40Z",
  "published_at": "2021-04-09T15:44:43Z",
  "assets": [

  ],
  "tarball_url": "https://api.github.com/repos/python-poetry/poetry-core/tarball/1.0.3",
  "zipball_url": "https://api.github.com/repos/python-poetry/poetry-core/zipball/1.0.3",
  "body": "### Fixed\r\n\r\n- Fixed an error when handling single-digit Python markers ([#156](https://github.com/python-poetry/poetry-core/pull/156)).\r\n- Fixed dependency markers not being properly copied when changing the constraint ([#163](https://github.com/python-poetry/poetry-core/pull/163))."
}

https://api.github.com/repos/python-poetry/poetry-core/releases/latest

Aaaaand I guess I'll file an issue with nix-update. Mic92/nix-update#11

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/nix/store/i87c24m0qfc74sn129kvi1vp10v8q721-python3.8-poetry-1.1.5
/nix/store/6jc3mkajfjc50s7s05fwa22jlsjkbfzs-python3.8-poetry-1.1.6
/nix/store/1p9yz3lhbgf2c20l8yw3sr1cmg5a6li6-python3.8-poetry-core-1.0.3

@mweinelt mweinelt merged commit 2f8f140 into NixOS:staging-next Apr 21, 2021
@jonringer jonringer deleted the fix-poetry branch April 21, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants