Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash-identifier: init at 1.2 #127490

Merged
merged 1 commit into from
Jun 26, 2021
Merged

hash-identifier: init at 1.2 #127490

merged 1 commit into from
Jun 26, 2021

Conversation

ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Jun 19, 2021 •
edited
Loading

Motivation for this change

https://gitlab.com/kalilinux/packages/hash-identifier

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ethancedwards8
Copy link
Member Author

Result of nixpkgs-review pr 127490 run on x86_64-darwin 1

1 package built:
  • hash-identifier

@ethancedwards8
Copy link
Member Author

Result of nixpkgs-review pr 127490 run on x86_64-linux 1

1 package built:
  • hash-identifier

@ethancedwards8 ethancedwards8 force-pushed the hash-identifier branch 2 times, most recently from e64c0e6 to 69843bb Compare June 20, 2021 17:39
@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 20, 2021 •
edited
Loading

Result of nixpkgs-review pr 127490 at 69843bbb run on aarch64-linux 1

1 package built successfully:
  • hash-identifier
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/security/hash-identifier/default.nix:14:3:

       |
14 |   installPhase = ''
   |   ^

Result of nixpkgs-review pr 127490 at c33a3e03 run on x86_64-linux 1

1 package built successfully:
  • hash-identifier
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/security/hash-identifier/default.nix:14:3:

       |
14 |   installPhase = ''
   |   ^

@ethancedwards8
Copy link
Member Author

Worth noting I still can't figure out patchShebangs, as in this doens't work yet. It stays as /usr/bin/env python in the final script.

@SuperSandro2000 SuperSandro2000 merged commit 3e64313 into NixOS:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@jonringer jonringer jonringer left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethancedwards8 @r-rmcgibbo @fabaff @SuperSandro2000 @jonringer