Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.aqualogic: 2.6 -> 3.3 #129538

Merged
merged 1 commit into from
Jul 7, 2021
Merged

python3Packages.aqualogic: 2.6 -> 3.3 #129538

merged 1 commit into from
Jul 7, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jul 7, 2021

Motivation for this change

Update to latest upstream release 3.3

Change log: swilson/aqualogic@2.6...3.3

Tests are no passing (swilson/aqualogic#9).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners July 7, 2021 14:14
@fabaff
Copy link
Member Author

fabaff commented Jul 7, 2021

Result of nixpkgs-review pr 129538 run on x86_64-linux 1

2 packages built:
  • python38Packages.aqualogic
  • python39Packages.aqualogic

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 7, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Jul 7, 2021 •
edited
Loading

Result of nixpkgs-review pr 129538 at 3d3f667 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.aqualogic
  • python39Packages.aqualogic

Result of nixpkgs-review pr 129538 at 3d3f667 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.aqualogic
  • python39Packages.aqualogic

jonringer
jonringer approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 129538 run on x86_64-linux 1

2 packages built:
  • python38Packages.aqualogic
  • python39Packages.aqualogic

@jonringer jonringer merged commit ce35e28 into NixOS:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @r-rmcgibbo @jonringer