Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smlnj: 110.95 -> 110.99.3 #190186

Closed
wants to merge 3 commits into from
Closed

smlnj: 110.95 -> 110.99.3 #190186

wants to merge 3 commits into from

Conversation

pi314mm
Copy link

@pi314mm pi314mm commented Sep 7, 2022

Description of changes

updated smlnj to 110.99.3

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@onny
Copy link
Contributor

onny commented Sep 8, 2022

LGTM, please squash commits. Also change PR and commit title format to smlnj: 110.95 -> 110.99.3

@pi314mm pi314mm changed the title smlnj 110.95 -> 110.99.3 smlnj: 110.95 -> 110.99.3 Sep 9, 2022
pkgs/development/compilers/smlnj/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/smlnj/default.nix Outdated Show resolved Hide resolved
@marsam marsam mentioned this pull request Sep 18, 2022
13 tasks
@lvitaly
Copy link
Contributor

lvitaly commented Sep 18, 2022

By the way, this update of the smlnj should bring apple silicon support under the Rosetta2 translator (see 110.99.1) as well as the support of macOS 13 (see 110.99.3). It would be great to know that apple silicon will be covered by nix as well 🙏

pi314mm and others added 2 commits September 22, 2022 18:13
Co-authored-by: Sandro <[email protected]>
@onny
Copy link
Contributor

onny commented Sep 29, 2022

Please squash commits :)

@SuperSandro2000
Copy link
Member

darwin fails to build with ../../config/gen-posix-names.sh: line 85: xcrun: command not found

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 1, 2024
@wegank
Copy link
Member

wegank commented Nov 1, 2024

Closed by #329975.

@wegank wegank closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants